[Merged by Bors] - chore: delete Init.Data.Fin.Basic
#15762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Parcly-Taxel
commented
Aug 13, 2024
Parcly-Taxel
commented
Parcly-Taxel
added
the
tech debt
PR summary d620d3df16
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Init.Data.Fin.Basic | 1 | 0 | -1 (-100.00%) |
| Mathlib.Data.List.Nodup | 329 | 328 | -1 (-0.30%) |
| Mathlib.Data.List.Range | 335 | 334 | -1 (-0.30%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 3292 files with changed transitive imports: this is too many to display! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
jcommelin
reviewed
Aug 13, 2024
Comment on lines
-29
to
-30
| -- These two aren't deprecated because `ne_of_val_ne` and `val_ne_of_ne` | ||
| -- use `¬a = b` instead of `a ≠ b`. TODO: fix or rename in Lean core. |
There was a problem hiding this comment.
This comment has not been addressed. But seemingly this syntactic difference does not cause any problems in mathlib.
There was a problem hiding this comment.
Can we open a PR to core that changes these two lemmas to use ≠? That seems uncontroversial to me.
There was a problem hiding this comment.
jcommelin
reviewed
Aug 13, 2024
Parcly-Taxel
added a commit
to Parcly-Taxel/lean4
that referenced
this pull request
Aug 13, 2024
Instead of a `Not (Eq …)` term use the proper `≠` in `Fin.ne_of_val_ne`, to make it symmetric with `Fin.val_ne_of_ne`, and move the former to the same place as the latter. This answers a query of @eric-weiser at leanprover-community/mathlib4#15762 (comment)
github-merge-queue bot
pushed a commit
to leanprover/lean4
that referenced
this pull request
Aug 14, 2024
Instead of a `Not (Eq …)` term use the proper `≠` in `Fin.ne_of_val_ne`, to make it symmetric with `Fin.val_ne_of_ne`, and move the former to the same place as the latter. This answers a query of @eric-wieser at leanprover-community/mathlib4#15762 (comment)
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Init.Data.Fin.BasicInit.Data.Fin.Basic
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.