-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rw ... at h
unknown fvar bug
#2728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 21, 2023
|
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
9c99b3e
to
a21deb5
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
awaiting-review |
a21deb5
to
639b9d8
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 25, 2023
* move `replaceLocalDecl` outside `Term.withSynthesize`
* about `Term.withSynthesize`
639b9d8
to
e871326
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
Waiting for someone to review the PR
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contribution Guidelines.
Second half of fixing #2711. Simply moves
replaceLocalDecl
outside ofTerm.withSynthesize
, but does not fix the general issues mentioned in #2727.This was benched on mathlib against nightly testing here. Note: this is actually a couple of commits off the baseline, which likely account for a couple things getting faster.
To find the relevant mathlib4 branches on speedcenter manually, search "2712" and compare the branch
bench-nightly-testing-for-2712
(baseline of #2712, which this PR depends on) tolean-pr-testing-2728
.Note: it took a while to get mathlib and std synced up to the current lean changes; the mathlib build failures were unrelated to this PR. This PR doesn't require any changes to mathlib or std.
instantiateMVars
toreplaceLocalDecl
#2712