Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rw ... at h unknown fvar bug #2728

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

thorimur
Copy link
Contributor

@thorimur thorimur commented Oct 21, 2023

Second half of fixing #2711. Simply moves replaceLocalDecl outside of Term.withSynthesize, but does not fix the general issues mentioned in #2727.


This was benched on mathlib against nightly testing here. Note: this is actually a couple of commits off the baseline, which likely account for a couple things getting faster.

To find the relevant mathlib4 branches on speedcenter manually, search "2712" and compare the branch bench-nightly-testing-for-2712 (baseline of #2712, which this PR depends on) to lean-pr-testing-2728.

Note: it took a while to get mathlib and std synced up to the current lean changes; the mathlib build failures were unrelated to this PR. This PR doesn't require any changes to mathlib or std.


@thorimur thorimur changed the title Rw with synthesize fix fix: rw ... at h unknown fvar bug Oct 21, 2023
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 21, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 21, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Oct 21, 2023

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 22, 2023
@thorimur thorimur force-pushed the rw-withSynthesize-fix branch from 9c99b3e to a21deb5 Compare October 22, 2023 01:24
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 22, 2023
@thorimur thorimur marked this pull request as ready for review October 23, 2023 05:59
@thorimur
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Oct 23, 2023
@kim-em kim-em self-assigned this Oct 24, 2023
@thorimur thorimur force-pushed the rw-withSynthesize-fix branch from a21deb5 to 639b9d8 Compare October 24, 2023 22:20
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 25, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Oct 25, 2023
* move `replaceLocalDecl` outside `Term.withSynthesize`
* about `Term.withSynthesize`
@thorimur thorimur force-pushed the rw-withSynthesize-fix branch from 639b9d8 to e871326 Compare October 25, 2023 00:47
@kim-em kim-em enabled auto-merge (squash) October 25, 2023 01:21
@kim-em kim-em merged commit 6063deb into leanprover:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants