fix: add instantiateMVars to replaceLocalDecl
#2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorimur
force-pushed
the
replaceLocalDecl-instantiateMVars
branch
2 times, most recently
from
09a2ff9 to
80017dd
Compare
|
!bench |
kim-em
reviewed
Oct 19, 2023
|
Here are the benchmark results for commit 80017dd. |
|
WIP |
github-actions
bot
added
the
WIP
thorimur
force-pushed
the
replaceLocalDecl-instantiateMVars
branch
2 times, most recently
from
4ddc3bb to
c95cf65
Compare
2 tasks
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 21, 2023
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
|
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
thorimur
force-pushed
the
replaceLocalDecl-instantiateMVars
branch
from
c95cf65 to
e56563d
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
leanprover-community-mathlib4-bot
added
builds-mathlib
|
awaiting-review |
github-actions
bot
added
awaiting-review
kim-em
reviewed
Oct 24, 2023
Comment on lines
19
to
23
| However, if it encounters a metavariable during this traversal, it simply continues traversing, | ||
| even if this metavariable is assigned to an expression which contains an `FVarId` occurring after | ||
| `fvarId`. This can lead to `replaceLocalDecl` inserting a local declaration with a type which | ||
| depends on `FVarId`s which come after it in the local context, thus creating unknown `FVarId`s (the | ||
| `FVarId`s of the local declarations after the insertion are modified). |
There was a problem hiding this comment.
Can you clarify that this is describing the previous behaviour (which would have caused this test to fail)?
There was a problem hiding this comment.
Okay, done in fbc8de6.
thorimur
force-pushed
the
replaceLocalDecl-instantiateMVars
branch
from
e56563d to
fbc8de6
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 24, 2023
leanprover-community-mathlib4-bot
added
breaks-mathlib
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contribution Guidelines.
First half of fixing #2711. (Second half is #2728.) Makes
replaceLocalDeclmore robust by inserting aninstantiateMVars. It should now be less possible to introduce an unknown free variable byreplaceLocalDeclalone. This affects manyattactics.However, this might not safeguard against all errors—in particular, mvars can still be synthesized to later-occurring fvars after the fact. See issue #2727.
This was benched on mathlib against nightly testing here. There didn't seem to be significant changes.
To find the relevant mathlib4 branches on speedcenter manually, search "2712" and compare the branch
bench-nightly-testing-for-2712(baseline) tolean-pr-testing-2712.Note: it took a while to get mathlib and std synced up to the current lean changes; the mathlib build failures were unrelated to this PR. This PR doesn't require any changes to mathlib or std.