[Merged by Bors] - chore: backports anticipating nightly-2024-05-19 #13046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
YaelDillies
approved these changes
May 20, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 20, 2024
This backports some changes that fill in a few implicit arguments. nightly-2024-05-19 has trouble with these and the bug fix in leanprover/lean4#4206, and needs some fixes. I *think* all these changes are not actually problematic, and perhaps even improve readability. If a maintainer agrees, let's just do this on master. If any of these look at all bad, please just say so and I'll remove it from this PR and consider doing a minimization to understand if/why it is really necessary.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
This backports some changes that fill in a few implicit arguments. nightly-2024-05-19 has trouble with these and the bug fix in leanprover/lean4#4206, and needs some fixes. I *think* all these changes are not actually problematic, and perhaps even improve readability. If a maintainer agrees, let's just do this on master. If any of these look at all bad, please just say so and I'll remove it from this PR and consider doing a minimization to understand if/why it is really necessary.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
This backports some changes that fill in a few implicit arguments. nightly-2024-05-19 has trouble with these and the bug fix in leanprover/lean4#4206, and needs some fixes. I *think* all these changes are not actually problematic, and perhaps even improve readability. If a maintainer agrees, let's just do this on master. If any of these look at all bad, please just say so and I'll remove it from this PR and consider doing a minimization to understand if/why it is really necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports some changes that fill in a few implicit arguments.
nightly-2024-05-19 has trouble with these and the bug fix in leanprover/lean4#4206, and needs some fixes.
I think all these changes are not actually problematic, and perhaps even improve readability.
If a maintainer agrees, let's just do this on master. If any of these look at all bad, please just say so and I'll remove it from this PR and consider doing a minimization to understand if/why it is really necessary.