Merge bounds handling into _DimensionalMetadata class. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to SciTools#3422
This is a much simpler alternative to #6
It moves the bounds-handling 'extension code' from methods of Coord into the _DimensionalMetadata class, to avoid replicating parts of the parent code within the child class.
The Coord class no longer has its own methods for
__eq__,__neg__or__binary_operator__: The parent implementation does it all.Aside :
I have left the
__str__and__repr__implementations as they were. I still think they could be improved though. The reworking of_str_dates_done in #6 will probably be a useful simplification here too.