Ancil var strict #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2019
lbdreyer
reviewed
Oct 23, 2019
| @@ -173,7 +159,8 @@ def copy(self, values=None): | |||
|
|
|||
| return new_metadata | |||
|
|
|||
| def _sanitise_array(self, src, ndmin): | |||
| @staticmethod | |||
| def _sanitise_array(src, ndmin): | |||
There was a problem hiding this comment.
We could still make _sanitise_array a static method in #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: do not merge
Presented for discussion, relating to SciTools#3422.
This is a prototype implementation of how we could store coordinate bounds as a separate _DimensionalMetadata component object, so we can use the same code to manage points + bounds in indexing or arithmetic operations (+ possibly others).
The parent _DimensionalMetadata class no longer contains any bounds-related code.
Compare with #7.
This is ultimately a tidier approach, but not entirely straightforward : there are still test failures here to resolve.