Use custom attributes in lt/lte/gt/gte rules messages #29715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nauthorized" message to exception.
[5.9] Use POST method when re-sending email verfication.
[5.9] Don't set default message when denying policy, move "This action is unauthorized" message to exception.
[5.9] Convert Arrayable Eloquent casted attributes to Array.
[5.9] Handle array and object values when updating JSON fields
[5.9] Queue cookies with same name and distinct paths
we can depend on `Illuminate\Contracts\Queue\Factory` in the `Illuminate\Queue\Worker` instead of the concrete manager instance. This allows for decorating the QueueManager with extra functionality. This solves the issues encountered in [27826](laravel#27826) and [laravel#29225](laravel#29225).
# Conflicts: # src/Illuminate/Database/Query/Grammars/MySqlGrammar.php # src/Illuminate/Database/Query/Grammars/PostgresGrammar.php # src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php
…n-tests [6.0] Add LazyCollection tests
…n-is-lazy [6.0] Test LazyCollection is lazy
Container. This is part of making the community aware that for most cases Manager doesn't not require an implementation of Application contracts and Container should be sufficient such as being used by Lumen. Laravel itself only extends Illuminate\Support\Manager for the following classes: - Illuminate\Hashing\HasManager - Illuminate\Mail\TransportManager - Illuminate\Notifications\ChannelManager - Illuminate\Session\SessionManager Signed-off-by: Mior Muhammad Zaki <[email protected]>
This is a follow-up for laravel#29619 Mior correctly noted that Managers only need to have a container instance to function properly. The fact that the default container we inject here is an instance of the Laravel application is an implementation detail. This PR contains no breaking changes other than renaming the $app property to $container. The new type-hint still allows for the current Application instance to be passed through but makes it clear that this could be any implementation of a container. I've also made $config a dedicated property on the Manager class as it's widely used on our own adapters. This makes it easy to reference it. The container array calls were replaced by `make` methods because `ArrayAccess` isn't part of the Container contract (and it shouldn't be).
…move-mutating-methods [6.0] Remove mutating methods from lazy collection
[5.8] Added ability to granulary set tries & timeout to Broadcast events
[7.0] Update versions for 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #29441