lte/gte/gt/lt not using custom attribute labels

[tillkruss]

• Laravel Version: 5.8.31
• PHP Version: 7.3

Description:

When using the lte or gte rules with a field, the custom attribute names aren't being used.

Expected:

The maximum price must be greater than or equal minimum price.

Actual result:

The maximum price must be greater than or equal price.min.

Notice that it not says:

The price.max must be greater than or equal price.min.

Steps To Reproduce:

$rules = [
    'price' => ['nullable', 'array', 'size:2'],
    'price.min' => ['nullable', 'numeric', 'min:1', 'lte:price.max'],
    'price.max' => ['nullable', 'numeric', 'min:1', 'gte:price.min'],
];

// validation attributes

return [
    'price.min' => 'minimum price',
    'price.max' => 'maximum price',
];

[driesvints]

Does it work when you use price_min instead? I think this is probably conflicting with dot notation.

[tillkruss]

price_min isn't a field on the request. This is the HTML:

<input type="number" step="any" min="1" name="price[min]">
<input type="number" step="any" min="1" name="price[max]">

[driesvints]

@tillkruss I'm trying to figure out if the dots are indeed the issue here so can you try with the price_min naming?

[tillkruss]

I was just testing that, you're too fast. Same error:

The maximum price must be greater than or equal price_min.

I'll try simple fields, one moment.

[tillkruss]

If the field has a value then I get a better message:

The maximum price must be greater than or equal 20.

But if the field is empty, either as array price[min] or a regular field price_min I get the same message:

The maximum price must be greater than or equal price.min.
The maximum price must be greater than or equal price_min.

In my particular case, the min and max fields are nullable, because it's not a required field.

[driesvints]

What if you try this in your validation translation file?

return [
    'price' => [
        'min' => 'minimum price',
        'max' => 'maximum price',
    ],
];

[tillkruss]

I did try that initially, but it didn't work:

return [
    'attributes' => [
        'price.min' => 'minimum price',
        'price.max' => 'maximum price',
        'price' => [
            'min' => 'minimum price',
            'max' => 'maximum price',
        ],
    ],
];

[driesvints]

Okay, just tested this with the setup from the original comment and everything works as expected:

master $ http --json POST test-app.test/foo price:='{"min":5, "max":4}'                                                                                                      ~/Sites/test-app
HTTP/1.1 422 Unprocessable Entity
Cache-Control: no-cache, private
Connection: keep-alive
Content-Type: application/json
Date: Fri, 09 Aug 2019 11:58:09 GMT
Server: nginx/1.17.0
Set-Cookie: laravel_session=eyJpdiI6IkxFRXBTQlMxSzIwZW9WRFlCMnd4b2c9PSIsInZhbHVlIjoiRjhmVExTd29oeDc2UmQ3TGlKYmxHbm1yT05oMmNKTzFuWGRWTXNWQzZERWhUcDlWZmlLbnpsVVVqR2RBc2FXRCIsIm1hYyI6ImU1ODVhMDY2ZGQ1NjlkMDUwYjQ3ZGJhYjBhMDYyY2NmNjQwMzQ4MjJlNzdjYTVmNjg3ODA5NTJmNDU5Mzg4NmMifQ%3D%3D; expires=Fri, 09-Aug-2019 11:59:09 GMT; Max-Age=60; path=/; httponly
Transfer-Encoding: chunked
X-Powered-By: PHP/7.3.5

{
    "errors": {
        "price.max": [
            "The maximum price must be greater than or equal 5."
        ]
    },
    "message": "The given data was invalid."
}

So not sure if we're missing anything here?

[driesvints]

I do think the default should be The :attribute must be greater than or equal to :value. (notices the extra "to").

[tillkruss]

Correct, now try it with min or max missing:

http --json POST test-app.test/foo price:='{"min":null, "max":4}' 

[driesvints]

I can reproduce it now. Not sure what's going wrong here.