[5.8] Added PutenvAdapter to env() helper

[kieranbrown]

Overview

This is related to an already reported issue: #27769.

The default behavior of PHP will not load environment variables into $_ENV and can only be retrieved using the getenv function.

; This directive determines which super global arrays are registered when PHP
; starts up. G,P,C,E & S are abbreviations for the following respective super
; globals: GET, POST, COOKIE, ENV and SERVER. There is a performance penalty
; paid for the registration of these arrays and because ENV is not as commonly
; used as the others, ENV is not recommended on productions servers. You
; can still get access to the environment variables through getenv() should you
; need to.
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS";
; http://php.net/variables-order
variables_order = "GPCS"

There are issues currently with not being able to retrieve physical server environment variables.

Proposed Solution

Include the PutenvAdapter to keep the same behavior prior to 5.8.

[GrahamCampbell]

This adapter was intentionally removed to stop variables from leaking into Laravel apps due to the non-thread-safety of getenv and putenv.

[GrahamCampbell]

You can still have this old behaviour in your app if you need it, by just extending Laravel's bootstrapper in your own app, and changing the one used in your http and console kernels.

[kieranbrown]

@GrahamCampbell Thanks for the reply, how would this work in Lumen? We set our environment variables in Docker so there is no .env file, thus no Dotenv bootstrap process. The only solution I can think of to make these variables accessible is to change config to load them into $_ENV or $_SERVER.

Would you suggest doing that, or adding a .env file and using the "LoadEnvironmentVariables" bootstrapper in Lumen?

I'm confused how the latter would work in a production environment because Lumen can't cache these environment variables into config during the build process.

Appreciate your help.

[kieranbrown]

For anybody else wondering, this got merged in eventually. See #27958