Add is_nullable method to check for NULLABLE mode (googleapis#3620)

Resolves: googleapis#3548
landrito · Aug 21, 2017 · 70621da · 70621da
1 parent 28031cb
commit 70621da
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/bigquery/google/cloud/bigquery/dbapi/cursor.py b/bigquery/google/cloud/bigquery/dbapi/cursor.py
@@ -76,7 +76,7 @@ def _set_description(self, schema):
                 internal_size=None,
                 precision=None,
                 scale=None,
-                null_ok=field.mode == 'NULLABLE')
+                null_ok=field.is_nullable)
             for field in schema])
 
     def _set_rowcount(self, query_results):

diff --git a/bigquery/google/cloud/bigquery/schema.py b/bigquery/google/cloud/bigquery/schema.py
@@ -65,6 +65,11 @@ def mode(self):
         """
         return self._mode
 
+    @property
+    def is_nullable(self):
+        """Check whether 'mode' is 'nullable'."""
+        return self._mode == 'NULLABLE'
+
     @property
     def description(self):
         """Optional[str]: Description for the field."""

diff --git a/bigquery/tests/unit/test_schema.py b/bigquery/tests/unit/test_schema.py
@@ -74,6 +74,16 @@ def test_mode_property(self):
         schema_field = self._make_one('again', 'FLOAT', mode=mode)
         self.assertIs(schema_field.mode, mode)
 
+    def test_is_nullable(self):
+        mode = 'NULLABLE'
+        schema_field = self._make_one('test', 'FLOAT', mode=mode)
+        self.assertTrue(schema_field.is_nullable)
+
+    def test_is_not_nullable(self):
+        mode = 'REPEATED'
+        schema_field = self._make_one('test', 'FLOAT', mode=mode)
+        self.assertFalse(schema_field.is_nullable)
+
     def test_description_property(self):
         description = 'It holds some data.'
         schema_field = self._make_one(