Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Add is_nullable method to check for NULLABLE mode #3620

Merged
merged 2 commits into from
Jul 18, 2017
Merged

BigQuery: Add is_nullable method to check for NULLABLE mode #3620

merged 2 commits into from
Jul 18, 2017

Conversation

sonlac
Copy link
Contributor

@sonlac sonlac commented Jul 18, 2017

Resolves: #3548

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 18, 2017
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 18, 2017
@tseaver
Copy link
Contributor

tseaver commented Jul 18, 2017

@sonlac Thank you very much for the patch! Could you please add tests for the is_nullable property in tests/unit/test_schema.py?

@sonlac
Copy link
Contributor Author

sonlac commented Jul 18, 2017

@tseaver Done. Thank you for reviewing.

@tseaver tseaver merged commit 86c77ef into googleapis:master Jul 18, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@sonlac @landrito
Add is_nullable method to check for NULLABLE mode (googleapis#3620)
70621da 
Resolves: googleapis#3548
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@sonlac @landrito
Add is_nullable method to check for NULLABLE mode (googleapis#3620)
ab971dc 
Resolves: googleapis#3548
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@sonlac @landrito
Add is_nullable method to check for NULLABLE mode (googleapis#3620)
6b91157 
Resolves: googleapis#3548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonlac @googlebot @tseaver