Class imcompatiblity

[gaetan-petit]

BC Break Report

Q	A
Version	4.4.0

Summary

Ugrading to 4.4.0 in a Symfony 3.4 application cause compatibility error.

Current behavior

composer update 
Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "3.4.*"
Updating dependencies
Lock file operations: 0 installs, 5 updates, 2 removals
  - Removing laminas/laminas-eventmanager (3.3.1)
  - Removing laminas/laminas-zendframework-bridge (1.2.0)
  - Upgrading laminas/laminas-code (4.3.0 => 4.4.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 2 removals
  - Downloading laminas/laminas-code (4.4.0)
  - Downloading phpstan/phpstan (0.12.90)
  - Removing laminas/laminas-zendframework-bridge (1.2.0)
  - Removing laminas/laminas-eventmanager (3.3.1)
  - Upgrading laminas/laminas-code (4.3.0 => 4.4.0): Extracting archive
Generating autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class

Symfony operations: 2 recipes (5471d04139cfeb8c88ad90ba4a997ba1)
  - Unconfiguring laminas/laminas-zendframework-bridge (>=1.2.0): From auto-generated recipe
  - Unconfiguring laminas/laminas-eventmanager (>=3.3.1): From auto-generated recipe
Executing script cache:clear --no-warmup [KO]
 [KO]
Script cache:clear --no-warmup returned with error code 255
!!  PHP Fatal error:  Could not check compatibility between Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Zend\Code\Generator\ClassGenerator $classGenerator) and ProxyManager\ProxyGenerator\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Laminas\Code\Generator\ClassGenerator $classGenerator), because class Zend\Code\Generator\ClassGenerator is not available in /var/www/marketplace/vendor/symfony/proxy-manager-bridge/LazyProxy/PhpDumper/LazyLoadingValueHolderGenerator.php on line 25

How to reproduce

Running composer update on application.

[Ocramius]

I would report this in upstream symfony: a dependency to `laminas/laminas-code` is missing there, and needs to be declared explicitly.

…

On Fri, Jun 18, 2021, 09:45 Gaëtan Petit ***@***.***> wrote: BC Break Report Q A Version 4.4.0 Summary Ugrading to 4.4.0 in a Symfony 3.4 application cause compatibility error. Current behavior composer update Loading composer repositories with package information Restricting packages listed in "symfony/symfony" to "3.4.*" Updating dependencies Lock file operations: 0 installs, 5 updates, 2 removals - Removing laminas/laminas-eventmanager (3.3.1) - Removing laminas/laminas-zendframework-bridge (1.2.0) - Upgrading laminas/laminas-code (4.3.0 => 4.4.0) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 5 updates, 2 removals - Downloading laminas/laminas-code (4.4.0) - Downloading phpstan/phpstan (0.12.90) - Removing laminas/laminas-zendframework-bridge (1.2.0) - Removing laminas/laminas-eventmanager (3.3.1) - Upgrading laminas/laminas-code (4.3.0 => 4.4.0): Extracting archive Generating autoload files composer/package-versions-deprecated: Generating version class... composer/package-versions-deprecated: ...done generating version class Symfony operations: 2 recipes (5471d04139cfeb8c88ad90ba4a997ba1) - Unconfiguring laminas/laminas-zendframework-bridge (>=1.2.0): From auto-generated recipe - Unconfiguring laminas/laminas-eventmanager (>=3.3.1): From auto-generated recipe Executing script cache:clear --no-warmup [KO] [KO] Script cache:clear --no-warmup returned with error code 255 !! PHP Fatal error: Could not check compatibility between Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Zend\Code\Generator\ClassGenerator $classGenerator) and ProxyManager\ProxyGenerator\LazyLoadingValueHolderGenerator::generate(ReflectionClass $originalClass, Laminas\Code\Generator\ClassGenerator $classGenerator), because class Zend\Code\Generator\ClassGenerator is not available in /var/www/marketplace/vendor/symfony/proxy-manager-bridge/LazyProxy/PhpDumper/LazyLoadingValueHolderGenerator.php on line 25 How to reproduce Running composer update on application. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#89>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEHIJ4HBCNDBCDIINSTTTL2RHANCNFSM465EOKFA> .

[gaetan-petit]

In our app several packages requires ocramius/proxy-manager (including symfony/proxy-manager-bridge) that require laminas/laminas-code
I'm not really familiar with the ProxyManagers where do you think the dependency is missing @Ocramius ?

[Ocramius]

`Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\LazyLoadingValueHolderGenerator` seems to use `zendframework/zend-code`, but it doesn't declare a dependency to it, hence why the class didn't get installed, and a crash occurs. The correct fix would be to declare a dependency there, and perhaps plan a migration to `laminas/laminas-code` too

…

On Fri, Jun 18, 2021, 10:04 Gaëtan Petit ***@***.***> wrote: In our app several packages requires ocramius/proxy-manager that require laminas/laminas-code I'm not really familiar with the ProxyManagers where do you think the dependency is missing @Ocramius <https://github.com/Ocramius> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEFGTMUM7N4XDIQ5NX3TTL4Z5ANCNFSM465EOKFA> .

[Ocramius]

Closing here: issue exists in symfony/symfony#41742, not here.

Suggestions have been made for upstream, but intentionally ignored.