[Composer] Added conflict with laminas/laminas-code:4.4.0 #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing build:
https://travis-ci.com/github/ezsystems/ezplatform/builds/229620437
Error:
Steps to reproduce:
composer create-project ezsystems/ezplatform:^2.5@dev
I've used PHP 7.4 and suspect that not all supported PHP versions are affects (see green build on PHP 7.1 in https://travis-ci.com/github/ezsystems/ezplatform/builds/229620437)
I've found that the issue is caused by the release of
laminas/laminas-code
4.4.0 (released yesterday):https://github.com/laminas/laminas-code/releases/tag/4.4.0
Installing this package version removes two other packages:
Based on the error message it looks like the error is caused by the lack of laminas-zendframework-bridge (https://github.com/laminas/laminas-zendframework-bridge/tree/1.3.x/src) which is adding some autoloading BC layer:
https://github.com/laminas/laminas-zendframework-bridge/blob/1.3.x/src/Autoloader.php#L117
The
Zend
namespace usage seems to come from symfony/proxy-manager-bridge:https://github.com/symfony/proxy-manager-bridge/blob/3.4/LazyProxy/PhpDumper/LazyLoadingValueHolderGenerator.php#L15
needed by ez-support-tools:
It is possible to install
laminas/laminas-zendframework-bridge
alongsidelaminas/laminas-code:4.4.0
:I feel like the best way to solve this would to be to add
laminas/laminas-zendframework-bridge
to one of the dependencies that's using it (symfony/proxy-manager-bridge?), but TBH I don't see the big picture in this list of dependencies right now.I've chosen to add a conflict as it's the quickest way to unblock Travis (and installation of development version of our product) - if you see a better way based on the data I've included here please let me know, I know that it will start failing as soon as laminas/laminas-code 4.4.1 is released.
Side:
Looks like removing
laminas/laminas-zendframework-bridge
would allow us to gain some performance (see: laminas/laminas-zendframework-bridge#83), so we should probably stive to remove the conflict in the future.