Refactor Mixer signal #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the common "onX" name for event handlers.
Name signal after what it represents, and keep type out of the name.
This limits visibility and potential for name conflict. Fixes Clang warning for flag `-Wmissing-variable-declarations`.
It seems slightly cleaner to setup event handling before asking the SDL Mixer subsystem to start delivering events. Similarly we should ask the SDL Mixer subsystem to stop delivering events before we remove the event handlers. Not that it really matters though, since the Signal class is safe to call when there are no handlers setup to delegate to.
cugone
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #528 (
-Wmissing-variable-declarations)Refactor
MixerSDLevent handling, and limit scope of file level variable to fix warning.