-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(runtime,serverless,cli): parallel requests to the same isolate #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 83ebcaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Following #616 where we allowed parallel requests between isolates, this PR allows parallel requests to the same isolate.
Events
Each isolate is now in its own thread, instead of having a pool of workers. The event loop is now constantly running for each isolate. They can receive two kinds of events: requests and termination.
Request events are added to a map of request id -> request context, and they are all polled in the event loop, and removed when the response has been sent. This is the heart of how parallel requests work. Termination events simply call
v8::Isolate::TerminateExeuction
.Limits
Another thread is spawned inside the isolate to apply CPU time limits. At each event loop tick, a "heartbeat" is sent. If no heartbeat has been sent during the function's maximum CPU time, the isolate is terminated.
As before, a near heap limit callback (
v8::Isolate::AddNearHeapLimitCallback
) is set and terminates the isolate when called.Misc
When an isolate is terminated, the correct termination result is sent for each ongoing request.
CPU time and memory usage are calculated after each response has been sent.
Performance
For a simple hello world:
Before: ~77k req/s
After: ~82k req/s