refactor(serverless): concurrent requests #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is the first step to support concurrent requests.
Previously, only a single isolate could run at the same time, due to a lock being acquired on a global map. If a request was blocking due to e.g a
setTimeout, all subsequent requests (including other deployments) would block and resume after the first was completed.This PR allows multiple isolates to run at the same time, across a pool of workers to better dispatch the work. It also introduces a new
LAGON_WORKERSenvironment variable to easily customize the size of the worker's pool. The next step is to start multiple times an isolate for a given deployment if it receives requests at the same time.As such, requesting multiple deployments at the same time (< LAGON_WORKERS) improves the number of req/s instead of decreasing it:
Before:
After: