Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model's shades not outputting #354

Closed
wants to merge 2 commits into from
Closed

fix: model's shades not outputting #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf3227
fix: model's shades not outputting
TfedUD Oct 31, 2024
21f456b
fix: removed old code line and updated src and U-obj
TfedUD Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions honeybee_grasshopper_core/src/HB Faces by Type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,12 @@ def add_face(face):
for ap in obj.orphaned_apertures:
add_aperture(ap)
for dr in obj.orphaned_doors:
add_door(dr)
outdoor_shades.extend(obj.orphaned_shades)
outdoor_shades.extend(obj.shade_meshes)
add_door(dr)
for shade in obj.shades:
if shade.is_indoor:
indoor_shades.append(shade)
elif shade.is_indoor == False:
outdoor_shades.append(shade)
elif isinstance(obj, Room):
add_shade(obj)
for face in obj:
Expand All @@ -162,4 +165,4 @@ def add_face(face):
elif isinstance(obj, Shade):
outdoor_shades.append(obj)
elif isinstance(obj, ShadeMesh):
outdoor_shades.append(obj)
outdoor_shades.append(obj)
Binary file modified honeybee_grasshopper_core/user_objects/HB Faces by Type.ghuser
View file
Open in desktop
Binary file not shown.