fix: model's shades not outputting #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriswmackey I couldn't assign you as a reviewer so I'm just tagging you here |
chriswmackey
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks for bringing this up, @TfedUD . You are right that there's a bug here but there are a few things about the PR that need to be changed. If you don't mind, I'll just open another PR that shows everything but, for future reference, you should export new user objects using this component.
|
This is how this PR should look like: So I am going to close out this one and merge the other. |
|
Thankyou for the information Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context for PR:
Problem:
HB faces by type not outputting shades from model, but outputting shades from rooms.
Fixed: