refactor(BA-627): Extract list_volumes and get_volume into pool.py (#3564) #3569
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
HyeockJinKim
reviewed
Feb 4, 2025
Comment on lines
+15
to
+29
| class VolumePool: | ||
| def __init__( | ||
| self, | ||
| local_config: Mapping[str, Any], | ||
| etcd: AsyncEtcd, | ||
| event_dispatcher: EventDispatcher, | ||
| event_producer: EventProducer, | ||
| backends: Mapping[str, Type[AbstractVolume]], | ||
| ): | ||
| self.local_config = local_config | ||
| self.etcd = etcd | ||
| self.event_dispatcher = event_dispatcher | ||
| self.event_producer = event_producer | ||
| self.backends = backends | ||
| self.volumes: dict[str, AbstractVolume] = {} |
There was a problem hiding this comment.
Can you add a type hint for instance variables to the class declaration?
And, set instance variable to private.
HyeockJinKim
reviewed
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3564 (BA-627)
Extracted
list_volumesandget_volumeintostorage/volumes/pool.py.Checklist: (if applicable)
ai.backend.testdocsdirectory📚 Documentation preview 📚: https://sorna--3569.org.readthedocs.build/en/3569/
📚 Documentation preview 📚: https://sorna-ko--3569.org.readthedocs.build/ko/3569/