Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract list_volumes and get_volume into pool.py #3564

Open
MintCat98 opened this issue Feb 3, 2025 — with Lablup-Issue-Syncer · 0 comments · May be fixed by #3569
Open

Extract list_volumes and get_volume into pool.py #3564

MintCat98 opened this issue Feb 3, 2025 — with Lablup-Issue-Syncer · 0 comments · May be fixed by #3569
Assignees

Comments

@MintCat98
Copy link

Motivation  

Currently, list_volumes and get_volume are located in context.py, but to improve modularity and maintainability, they should be moved to a separate storage/volumes/pool.py file.

Required Features

Move list_volumes and get_volume to pool.py in /storage/volumes/.

Impact  

  • Code Structure Improvement:

    • Increases cohesion by isolating volume management logic from context.py.
  • Enhanced Maintainability:

    • Easier to manage and modify volume-related logic independently.
  • Better Extensibility:

    • Future volume-related functionalities can be managed systematically within pool.py.
  • No Functional Change:

    • API behavior remains the same, ensuring no impact on external users.

Testing Scenarios  

  • Verify that list_volumes returns the same data as before.

  • Ensure get_volume correctly retrieves volume instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant