Include the track's tags into the GPX file #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2018 22:58
…cation, a separate namespaces should be used for such custom tags. I don't do it for the time being to be compliant with other appearances of "<extensions>" in this app.
|
Hi, thanks for your contribution! :D |
|
Oha, somewhere I lost the overview over my local branch mess and merged in something I shouldn't have merged. I (tried to) step back and apply the intended changes without polluting them with unrelated stuff. The resulting local branch name is now hz04_export_tags. It is supposed to contain the tags and description export stuff only. Problem: I don't know how to edit the existing PR to use this new branch. Maybe I have to close this PR and open a new one. I would rather avoid this to preserve the conversation history. If you don't mind, could you check whether hz04_export_tags is as you like? |
added 4 commits
June 22, 2019 08:21
…into hz_export_tags
…separated list. Seems to be more in line with GPX specs.
- trim leading/trailing whitespaces from tags in GPX
|
I think I found a way to push the fixed hz_export_tracks (reset, cherry-pick,force-push). Tested and it seems to be ok. |
|
Thanks for all your job and contributions! |
aton1698
added a commit
to aton1698/osmtracker-android
that referenced
this pull request
Sep 23, 2019
* Fix travis CI (labexp#202) * Fix ExportTrackTaskTest and Travis CI * Update gradle4.6-all checksum * Update travis config file * add travis config sudo:true * Fix issue 183 * Fix the problem when download a new layout after the export gpx directory changed * fix display of background maps (labexp#203) * Add load method which sets HTTP User Agent to the app package name * Ask for permissions before display track * Clean unused code in DisplayTrack * Request storage permission when exporting tracks any time * Add missing breaks - permissions requested propertly when exporting all traces * Request permissions when upload a trace to OSM * scale-up map to be better readable on high DPI displays * Set track width in map view to 0.5mm * Fix issue labexp#189, adding multiple tags to track (labexp#204) * Comment map tiles sources in preferences * Use always the default map tile source MAPNIK * Include the track's tags into the GPX file (labexp#166) * Include the tags in the GPX file * Fix: The "<tags>" was missing; actually, according to the GPX specification, a separate namespaces should be used for such custom tags. I don't do it for the time being to be compliant with other appearances of "<extensions>" in this app. * Fixed null issue when tags are empty * slight format adjustments * Export track description into GPX * replace <extensions><tags>... by <metadata><keywords>... * Export multiple tags as multiple <keyword> elements instead of comma separated list. Seems to be more in line with GPX specs. * - place <desc> also withing <metadata> - trim leading/trailing whitespaces from tags in GPX * Request GPS permission before start TrackLogger Activity, fix issue labexp#207 (labexp#213) * Changing the app version to 0.7.2-beta * Update the target sdk to 28 and the version code to 45 * Fix android9 and issues (labexp#218) * Target sdk 28 needs FOREGROUND_SERVICE permission in manifest. Fixes issue labexp#214 * Fix wrong imports and function calls from them * Fix background map for Android 9.0 to launch beta2 v0.7.2 * Fix some dependencies in manifest and gradle * Change dependencies, delete usage of http-android * Update version code * Comment tests that stop travis * Delete test class files
aton1698
pushed a commit
that referenced
this pull request
Oct 7, 2019
* New preference: Minimum distance between subsequent track points * Open keyboard automatically when creating a note Fixes issue #62 * update gradle and build tools versions * The bug that deletes the saved tags before save the trace is solved * New translations from Transifex * Do not allow empty string in min_logging_distance * Solving the issue #115 (#179) Adding new icon in the bottom space in the main screen * Changing app version to 0.7.1 * Fix travis CI (#202) * Fix ExportTrackTaskTest and Travis CI * Update gradle4.6-all checksum * Update travis config file * add travis config sudo:true * Fix issue 183 * Fix the problem when download a new layout after the export gpx directory changed * fix display of background maps (#203) * Add load method which sets HTTP User Agent to the app package name * Ask for permissions before display track * Clean unused code in DisplayTrack * Request storage permission when exporting tracks any time * Add missing breaks - permissions requested propertly when exporting all traces * Request permissions when upload a trace to OSM * scale-up map to be better readable on high DPI displays * Set track width in map view to 0.5mm * Fix issue #189, adding multiple tags to track (#204) * Comment map tiles sources in preferences * Use always the default map tile source MAPNIK * Include the track's tags into the GPX file (#166) * Include the tags in the GPX file * Fix: The "<tags>" was missing; actually, according to the GPX specification, a separate namespaces should be used for such custom tags. I don't do it for the time being to be compliant with other appearances of "<extensions>" in this app. * Fixed null issue when tags are empty * slight format adjustments * Export track description into GPX * replace <extensions><tags>... by <metadata><keywords>... * Export multiple tags as multiple <keyword> elements instead of comma separated list. Seems to be more in line with GPX specs. * - place <desc> also withing <metadata> - trim leading/trailing whitespaces from tags in GPX * Request GPS permission before start TrackLogger Activity, fix issue #207 (#213) * Update the target sdk to 28 and the version code to 45 * Fix android9 and issues (#218) * Target sdk 28 needs FOREGROUND_SERVICE permission in manifest. Fixes issue #214 * Fix wrong imports and function calls from them * Fix background map for Android 9.0 to launch beta2 v0.7.2 * Fix some dependencies in manifest and gradle - WIP * Change dependencies, delete usage of http-android * Update version code * Comment tests that stop travis * Delete test class files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the track's tags into the GPX file. Format:
Comment: According to the GPX specification, every element inside
<extensions>should use a private namespace, so actually it should read for example<osmtracker:tags>(only an example, the exact name would be up for discussion). I didn't do it because all other places in the app which use<extensions>also don't do it.