Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): enable delta by default #8262

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Nov 6, 2023

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Nov 6, 2023
@lahabana lahabana requested a review from a team as a code owner November 6, 2023 09:42
@lahabana lahabana requested review from Automaat and bartsmykla and removed request for a team November 6, 2023 09:42
@lobkovilya
Copy link
Contributor

Should we mention in UPGRADE.md that policies will be synced to the system namespace (instead of default namespace)? It shouldn't require any actions from the user to work, but the user may search policies in the wrong place after the upgrade

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana force-pushed the kdsEnabledByDefault branch from 76292bc to da3dfd4 Compare November 7, 2023 11:28
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
slonka
slonka previously requested changes Nov 8, 2023
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're setting something as default it shouldn't be called experimental.

UPGRADE.md Show resolved Hide resolved
@slonka slonka dismissed their stale review November 8, 2023 09:29

Dismissing because of #8290 until we have a agreed upon way.

Signed-off-by: Lukasz Dziedziak <[email protected]>
test/e2e/helm/e2e_suite_test.go Show resolved Hide resolved
@lukidzi lukidzi merged commit e148584 into kumahq:release-2.5 Nov 9, 2023
@lahabana lahabana deleted the kdsEnabledByDefault branch March 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants