Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MADR about new features/experiments lifecycle #8290

Open
lahabana opened this issue Nov 8, 2023 · 4 comments
Open

add MADR about new features/experiments lifecycle #8290

lahabana opened this issue Nov 8, 2023 · 4 comments
Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Nov 8, 2023

Description

We usually add new features/change of behaviours through "experiments".

We don't have a good practice around how experiments land as default.
Let's codify this in a MADR.

IMO here's what we should do:

  • land a new conf in experimental with a value of false
  • once the feature is mature switch it to true
  • once we're all ready with this remove the config altogether

This MADR should also make a difference between rewrites which should have experimental booleans and features that should just be added in the config.

For example we have ExperimentalKDSEventBasedWatchdog. It's unfortunate because if we were to make it not an experiment we'd need to ask people using it to change their config to adopt it.

This MADR should ensure we make it as easy as possible for people to adopt experiments and never need to change configs if the experiment is a success.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/design Design doc or related labels Nov 8, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 13, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 12, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Feb 12, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 13, 2024
@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label May 20, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 19, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Aug 19, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 18, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants