Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-server): implement new Global Insight endpoint #7775

Merged
merged 11 commits into from
Sep 21, 2023
Merged

feat(api-server): implement new Global Insight endpoint #7775

merged 11 commits into from
Sep 21, 2023

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Sep 16, 2023 •
edited by bartsmykla
Loading

Closes #7774

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat Automaat requested a review from a team as a code owner September 16, 2023 09:18
@Automaat Automaat requested review from michaelbeaumont and slonka and removed request for a team September 16, 2023 09:18
@michaelbeaumont michaelbeaumont changed the title feat(kuma-cp): Implement new Global Insight endpoint feat(kuma-cp): implement new Global Insight endpoint Sep 18, 2023
@kleinfreund kleinfreund mentioned this pull request Sep 18, 2023
Merged
@michaelbeaumont michaelbeaumont force-pushed the feat/global-insight branch 3 times, most recently from a37ad0f to 62ceaaa Compare September 20, 2023 10:55
@michaelbeaumont
chore: error msgs
6ccfb5a 
Signed-off-by: Mike Beaumont <[email protected]>
@bartsmykla bartsmykla self-requested a review September 21, 2023 07:20
@bartsmykla bartsmykla enabled auto-merge (squash) September 21, 2023 08:03
@bartsmykla bartsmykla merged commit daa9ad9 into kumahq:master Sep 21, 2023
@lahabana lahabana changed the title feat(kuma-cp): implement new Global Insight endpoint feat(api-server): implement new Global Insight endpoint Nov 3, 2023
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new Global Insight endpoint
3 participants
@Automaat @michaelbeaumont @bartsmykla