-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates global control plane health #1315
feat: updates global control plane health #1315
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to vertical alignment of the top section with the "Zones" heading and the create button? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for filling out out the mocks with randomness! I left a couple of comments one was a q, lmk other than that should be a 👍 from me.
Adds online figures to some of the stats shown in the global control plane health section. Expands the meshes table to include the online figures for DPPs. Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
Also removed fetchAllResources as we are no longer using it. 7a7d635 |
Signed-off-by: Philipp Rudloff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer!
Adds online figures to some of the stats shown in the global control plane health section.
Resolves #1346.
Depends on kumahq/kuma#7775.
Signed-off-by: Philipp Rudloff [email protected]