Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates global control plane health #1315

Merged
merged 4 commits into from
Sep 22, 2023
Merged

feat: updates global control plane health #1315

merged 4 commits into from
Sep 22, 2023

Conversation

kleinfreund
Copy link
Contributor

@kleinfreund kleinfreund commented Aug 10, 2023

Adds online figures to some of the stats shown in the global control plane health section.

Resolves #1346.

Depends on kumahq/kuma#7775.

Signed-off-by: Philipp Rudloff [email protected]

@kleinfreund kleinfreund self-assigned this Aug 10, 2023
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit b8c7c23
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/650c5e55043af300082c51a1
😎 Deploy Preview https://deploy-preview-1315--kuma-gui.netlify.app/gui
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but isn't this allignment wrong:

image

?

@kleinfreund
Copy link
Contributor Author

Unrelated to this PR but isn't this allignment wrong:

Are you referring to vertical alignment of the top section with the "Zones" heading and the create button?

@lahabana
Copy link
Contributor

Yes

@kleinfreund kleinfreund marked this pull request as ready for review September 21, 2023 10:07
@kleinfreund kleinfreund requested a review from a team as a code owner September 21, 2023 10:07
@kleinfreund kleinfreund requested review from johncowen and removed request for a team September 21, 2023 10:07
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for filling out out the mocks with randomness! I left a couple of comments one was a q, lmk other than that should be a 👍 from me.

src/app/main-overview/components/MainOverview.vue Outdated Show resolved Hide resolved
src/app/main-overview/sources.ts Show resolved Hide resolved
Philipp Rudloff added 3 commits September 21, 2023 17:10
Adds online figures to some of the stats shown in the global control plane health section.

Expands the meshes table to include the online figures for DPPs.

Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund
Copy link
Contributor Author

Also removed fetchAllResources as we are no longer using it. 7a7d635

Signed-off-by: Philipp Rudloff <[email protected]>
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@kleinfreund kleinfreund merged commit 8ae1db6 into kumahq:master Sep 22, 2023
@kleinfreund kleinfreund deleted the feat/update-global-control-plane-health branch September 22, 2023 05:41
@kleinfreund kleinfreund removed their assignment Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update overview (and mesh detail view) with online figures
3 participants