-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ExternalService): add skip hostname verification for external services #7633
feat(ExternalService): add skip hostname verification for external services #7633
Conversation
The external services were automatically doing verification for hostnames on TLS certificates when TLS is enabled. This update adds a flag to the external service definition to skip this verification. By default, it is false. Fix kumahq#7121 Signed-off-by: Alparslan Avci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I left a comment to change the field number
Signed-off-by: alparslanavci <[email protected]>
Signed-off-by: alparslanavci <[email protected]>
Thanks for the review, @lukidzi! I pushed a commit to update it. I'll appreciate it if you can have a look at it again. After the merge, I'll also send a PR to the docs repo. |
Hi @lukidzi, should I need to do anything for this PR? Please let me know if so! |
Merged, thanks for the contribution 👍 @alparslanavci |
The external services were automatically doing verification for hostnames on TLS certificates when TLS was enabled. This update adds a flag to the external service definition to skip this verification. By default, it is false.
Fix #7121
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?