Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot disable SNI in external service #5474

Closed
slonka opened this issue Dec 8, 2022 · 6 comments
Closed

Cannot disable SNI in external service #5474

slonka opened this issue Dec 8, 2022 · 6 comments
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Dec 8, 2022

What happened?

as per docs:

serverName overrides the default Server Name Indication. Set this value to empty string to disable SNI.

but when I actually try to do this I get:

The ExternalService "httpbin" is invalid: spec.networking.tls.serverName: cannot be empty

This is because of this validator code.
@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Dec 8, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 12, 2022
@jakubdyszkiewicz
Copy link
Contributor

Triage: let's lift validation for this

@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 13, 2023
@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Mar 14, 2023
@lahabana lahabana mentioned this issue Mar 22, 2023
Closed
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 13, 2023
@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Jun 22, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 21, 2023
@lobkovilya lobkovilya removed the triage/stale Inactive for some time. It will be triaged again label Sep 27, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz
Copy link
Contributor

Fixed by #7633

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@slonka @jakubdyszkiewicz @bartsmykla @lobkovilya @lukidzi