-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTV-1686] Simplify/update migration plan status cell (part 2) #1442
base: main
Are you sure you want to change the base?
Conversation
ba019b8
to
7a7bfc2
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 36.81% 35.65% -1.16%
==========================================
Files 158 546 +388
Lines 2548 9499 +6951
Branches 599 2166 +1567
==========================================
+ Hits 938 3387 +2449
- Misses 1428 5791 +4363
- Partials 182 321 +139 ☔ View full report in Codecov by Sentry. |
acb6a1c
to
3d530f4
Compare
packages/forklift-console-plugin/src/modules/Plans/views/list/components/VMsCell.tsx
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/views/list/components/PlanStatusVmCount.tsx
Show resolved
Hide resolved
...onsole-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCellLabel.tsx
Outdated
Show resolved
Hide resolved
...onsole-plugin/src/modules/Plans/views/list/components/PlanStatusCell/PlanStatusCellLabel.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanSummaryStatus.ts
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanSummaryStatus.ts
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdownItems.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeff Puzzo <[email protected]>
Signed-off-by: Jeff Puzzo <[email protected]>
8f9f40a
to
3e237ae
Compare
Signed-off-by: Jeff Puzzo <[email protected]>
packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getConditionTypes.ts
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdownItems.tsx
Outdated
Show resolved
Hide resolved
packages/forklift-console-plugin/src/modules/Plans/actions/PlanActionsDropdownItems.tsx
Outdated
Show resolved
Hide resolved
packages/common/src/components/LoadingSpinner/LoadingSpinner.tsx
Outdated
Show resolved
Hide resolved
c3d9a4c
to
6dbcc99
Compare
@@ -6,6 +6,7 @@ export * from './FormGroupWithHelpText'; | |||
export * from './HelpIconPopover'; | |||
export * from './Icons'; | |||
export * from './LoadingDots'; | |||
export { default as LoadingSpinner } from './LoadingSpinner'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add it to index file, we are going to remove those index's completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it looks like we cannot import components without linting/compliation errors with the following from @kubev2v/common
:
import LoadingSpinner from '@kubev2v/common/src/components/LoadingSpinner';
import LoadingSpinner from '@kubev2v/common/dist/components/LoadingSpinner';
Both of these lead to issues, and to solve this issue is to solve a much broader one which would deal with the exporting of components collectively from that repo within this monorepo.
So unless there's something else we can do in the meantime for this, I think adding this export to the existing index is the least invasive change without changing the scope of this issue right now.
e1ec19d
to
fe718c0
Compare
Signed-off-by: Jeff Puzzo <[email protected]>
fe718c0
to
6852ae1
Compare
Quality Gate passedIssues Measures |
📝 Links
Implementation criteria gathered from this design doc: https://docs.google.com/document/d/18HeL1gbw9_q_aLWg39f-kvt7q4rjXlsjTKuMCdZBHQQ/edit?tab=t.0#heading=h.i7p5ubi780ve.
📝 Description
This PR updates the terminology used within the plan migration status cell, updates the filter accordingly for the table, and updates some styling within the cell so that alignment matches the design screenshots seen in the document referenced above.
🎥 Demo
Screen.Recording.2025-01-22.at.2.20.29.PM.mov
📝 CC://
@heyethankim