Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTV-1686] Simplify/update migration plan status cell (part 2) #1442

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 22, 2025

📝 Links

References:
MTV-1686
Design issue: HPUX-201
Initial PR (part 1): #1411

Implementation criteria gathered from this design doc: https://docs.google.com/document/d/18HeL1gbw9_q_aLWg39f-kvt7q4rjXlsjTKuMCdZBHQQ/edit?tab=t.0#heading=h.i7p5ubi780ve.

📝 Description

This PR updates the terminology used within the plan migration status cell, updates the filter accordingly for the table, and updates some styling within the cell so that alignment matches the design screenshots seen in the document referenced above.

  • Added unit tests covering scenarios involved with the plan migration status cell.
  • Also added ability to read interpolations for unit tests using translated strings.

🎥 Demo

Screen.Recording.2025-01-22.at.2.20.29.PM.mov

📝 CC://

@heyethankim

@jpuzz0 jpuzz0 added the enhancement Categorizes issue or PR as related to a new feature. label Jan 22, 2025
@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from ba019b8 to 7a7bfc2 Compare January 22, 2025 19:25
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 35.65%. Comparing base (13484d0) to head (6852ae1).
Report is 212 commits behind head on main.

Files with missing lines Patch % Lines
...-console-plugin/src/modules/Plans/actions/utils.ts 15.00% 14 Missing and 3 partials ⚠️
...in/src/modules/Plans/utils/helpers/getPlanPhase.ts 38.09% 8 Missing and 5 partials ⚠️
...modules/Plans/actions/PlanActionsDropdownItems.tsx 20.00% 8 Missing ⚠️
...rc/modules/Plans/views/list/components/VMsCell.tsx 0.00% 3 Missing ⚠️
...odules/Plans/utils/helpers/getPlanSummaryStatus.ts 93.33% 2 Missing ⚠️
.../list/components/PlanStatusCell/PlanStatusCell.tsx 95.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   36.81%   35.65%   -1.16%     
==========================================
  Files         158      546     +388     
  Lines        2548     9499    +6951     
  Branches      599     2166    +1567     
==========================================
+ Hits          938     3387    +2449     
- Misses       1428     5791    +4363     
- Partials      182      321     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch 2 times, most recently from acb6a1c to 3d530f4 Compare January 27, 2025 15:44
@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from 8f9f40a to 3e237ae Compare January 28, 2025 16:33
@jpuzz0 jpuzz0 requested a review from metalice January 28, 2025 16:34
@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from c3d9a4c to 6dbcc99 Compare January 29, 2025 15:31
@@ -6,6 +6,7 @@ export * from './FormGroupWithHelpText';
export * from './HelpIconPopover';
export * from './Icons';
export * from './LoadingDots';
export { default as LoadingSpinner } from './LoadingSpinner';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add it to index file, we are going to remove those index's completely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it looks like we cannot import components without linting/compliation errors with the following from @kubev2v/common:

import LoadingSpinner from '@kubev2v/common/src/components/LoadingSpinner';
import LoadingSpinner from '@kubev2v/common/dist/components/LoadingSpinner';

Both of these lead to issues, and to solve this issue is to solve a much broader one which would deal with the exporting of components collectively from that repo within this monorepo.

So unless there's something else we can do in the meantime for this, I think adding this export to the existing index is the least invasive change without changing the scope of this issue right now.

@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from e1ec19d to fe718c0 Compare January 30, 2025 15:03
Signed-off-by: Jeff Puzzo <[email protected]>
@jpuzz0 jpuzz0 force-pushed the MTV-1686-more-status-updates branch from fe718c0 to 6852ae1 Compare January 30, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants