[MTV-1686] Simplify/update migration plan status cell #1411
Conversation
Signed-off-by: Jeff Puzzo <[email protected]>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
- Coverage 36.81% 36.21% -0.60%
==========================================
Files 158 159 +1
Lines 2548 2579 +31
Branches 599 615 +16
==========================================
- Hits 938 934 -4
- Misses 1428 1450 +22
- Partials 182 195 +13 ☔ View full report in Codecov by Sentry. |
| status: string; | ||
| }; | ||
|
|
||
| export const PlanStatusCell: React.FC<CellProps> = ({ data }) => { |
There was a problem hiding this comment.
nice refactor of the component name, status cell was too general
| icon={buttonCutoverIcon} | ||
| onClick={onClickPlanCutoverMigration} | ||
| > | ||
| <Button variant="secondary" icon={<CutoverIcon />} onClick={onClickPlanCutoverMigration}> |
There was a problem hiding this comment.
I guess we will remove this in a followup ...
There was a problem hiding this comment.
Right, at least for now, I think the design plan is to move this button to a "Migration type" column as seen here:
(can be seen in figma here)
|
@jpuzz0 @yaacov Few concerns regarding this PR. Please check the below screenshots as an example. Before
After
|
[MTV-1686] Simplify/update migration plan status cell Signed-off-by: Joachim Schuler <[email protected]>
|
@sgratch Met with @jpuzz0 for more context, and here are my answers to your questions above.
Yes, that's correct. The specific question was raised during the usability testing, and most participants were fine with the design. The "Start" button is the only exception. When the plan fails (incomplete), the "Restart" button doesn't display, as it can only be triggered through the kebab menu on the Plans page. Usability testing also confirmed that not a single participant would click on the button without first wanting to understand the issue. |
Good catch. @jpuzz0 will investigate further. |
We want to eliminate the inconsistency in the hyperlink behavior. Sometimes it links to a page, other times it triggers a modal. Most importantly, users want to investigate the issue directly on the detail page when an error occurs. Eventually, we plan to add a "Logs" tab to the detail page, which will clearly communicate what's happening and allow users to address the issue right there. |
|
@sgratch For the |
@jpuzz0 I don't have that environment anymore, but I assume it was a |
@jpuzz0 as expected, the difference is due to canceling one VM Please see the difference between old UI before this fix for plan name "
To new UI after this fix:
I'll open a bug on Jira so that we won't forget to handle this: |
https://issues.redhat.com/browse/MTV-1686
Summary
Updated UI presentation of migration plan status column cells.
Changes are outlined in this design ticket: https://issues.redhat.com/browse/HPUX-201
NOTE: This implementation does not match the design completely in terms of the status labels used. This is subject to change in future work related to the same design JIRA.
Before
After