Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-tenancy usage models blog post #27200

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Add multi-tenancy usage models blog post #27200

merged 6 commits into from
Apr 14, 2021

Conversation

JimBugwadia
Copy link
Contributor

@JimBugwadia JimBugwadia commented Mar 24, 2021 •
edited
Loading

Signed-off-by: Jim Bugwadia [email protected]

Blog post for Kubernetes Multi-Tenancy Usage Models

cc: @tashimi

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @JimBugwadia!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2021
@netlify
Copy link

netlify bot commented Mar 24, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1b162a0

https://deploy-preview-27200--kubernetes-io-master-staging.netlify.app

@tashimi
Copy link

tashimi commented Mar 24, 2021

/approve

tenor-265878761

sftim
sftim reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimBugwadia here's some feedback; I hope it's useful.

@sftim
Copy link
Contributor

sftim commented Mar 24, 2021

draft post for Kubernetes Multi-Tenancy Usage Models

/retitle [WIP] Add multi-tenancy usage models blog post

@k8s-ci-robot k8s-ci-robot changed the title multi-tenancy usage models blog post [WIP] Add multi-tenancy usage models blog post Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2021
@sftim
Copy link
Contributor

sftim commented Mar 24, 2021

@JimBugwadia feel free to mark this ready for review - remember to update the PR description too.

If you'd like help with any of this, feel free to ask!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 24, 2021
@sftim
Copy link
Contributor

sftim commented Mar 24, 2021

Prow doesn't let you mention GitHub users (to avoid people getting spammed if there's a fork of the commits).

If you squash commits @JimBugwadia, that'll fix it.

@JimBugwadia
Copy link
Contributor Author

Thanks Tim, will do!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 25, 2021
@JimBugwadia
Copy link
Contributor Author

/retitle Add multi-tenancy usage models blog post

@k8s-ci-robot
Copy link
Contributor

@JimBugwadia: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Add multi-tenancy usage models blog post

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JimBugwadia JimBugwadia requested a review from sftim March 25, 2021 00:47
@JimBugwadia
Copy link
Contributor Author

@sftim - I cleaned up the commits and have request a review. Thanks again!

@sftim
Copy link
Contributor

sftim commented Mar 25, 2021

Article preview

@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80cb912fd5d768f28ce8da2094b0cc64fb25073c

@mrbobbytables
Copy link
Member

Just as a heads up, the kube state metrics post is slated for 4/13 (to coincide with their release) would 4/15 work? That would make it the only post going live that day.

mrbobbytables
mrbobbytables reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, in addition to the out-of-band comment on the date, but overall looks good 👍

@sftim sftim mentioned this pull request Apr 12, 2021
Merged
@JimBugwadia
make links relative
0c549f3 
Signed-off-by: Jim Bugwadia <[email protected]>
@JimBugwadia
update publish date to 4/15
c907b1a 
Signed-off-by: Jim Bugwadia <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2021
sftim
sftim previously requested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now has no changes @JimBugwadia

I recommend you carefully rebase it - against master if feasible - and take care not to squash commits too eagerly.

@JimBugwadia
add file
1b162a0 
Signed-off-by: Jim Bugwadia <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
@sftim sftim dismissed their stale review April 12, 2021 21:38

It's back!

@JimBugwadia
Copy link
Contributor Author

Thanks, @sftim! I renamed the file but missed adding it! All good now.

@JimBugwadia
Copy link
Contributor Author

Article Preview

@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c0246f42922ef4b1943f4ac0f23fee67625c03b

@raesene
Copy link
Contributor

raesene commented Apr 13, 2021

lgtm

@savitharaghunathan
Copy link
Member

/lgtm

@sftim
Copy link
Contributor

sftim commented Apr 14, 2021

/approve
/hold cancel

Thanks @JimBugwadia

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, sftim, tashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@sftim
Copy link
Contributor

sftim commented Apr 14, 2021

Scheduled for 2021-04-15

@k8s-ci-robot k8s-ci-robot merged commit 17e45d8 into kubernetes:master Apr 14, 2021
PushkarJ
PushkarJ reviewed Apr 14, 2021
View reviewed changes
content/en/blog/_posts/2021-04-15-Three-Tenancy-Models-for-Kubernetes.md

## Security considerations

Cloud native security involves different system layers and lifecycle phases as described in the [Cloud Native Security Whitepaper](https://www.cncf.io/blog/2020/11/18/announcing-the-cloud-native-security-white-paper/) from CNCF SIG Security. Without proper security measures implemented across all layers and phases, Kubernetes tenant isolation can be compromised and a security breach with one tenant can threaten other tenants.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to link the kubernetes blog post instead of cncf blog post, for the cloud native security whitepaper: https://kubernetes.io/blog/2020/11/18/cloud-native-security-for-your-clusters/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either link. @PushkarJ the article isn't live so you might have time to propose a revision and get it reviewed.

My gut feeling is that, actually, for only a small tweak it is not worth the effort.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To close the loop here, PR #27555 updates the above link for whitepaper

@danpop-chainguard
Copy link

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PushkarJ PushkarJ PushkarJ left review comments

@adrianludwin adrianludwin adrianludwin left review comments

@sftim sftim sftim left review comments

@castrojo castrojo Awaiting requested review from castrojo

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@tengqm tengqm Awaiting requested review from tengqm

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@tashimi tashimi

@tengqm tengqm

@savitharaghunathan savitharaghunathan

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.