Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blog post on using kubectl annotate for human service discovery #26749

Merged
merged 16 commits into from
Apr 13, 2021
Merged

add blog post on using kubectl annotate for human service discovery #26749

merged 16 commits into from
Apr 13, 2021

Conversation

richarddli
Copy link
Contributor

We've found kubectl annotate to be a vastly underused and surprisingly useful part of Kubernetes, so I wrote a blog post about it. Feedback appreciated.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2021
@netlify
Copy link

netlify bot commented Feb 27, 2021 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f94b9bf

https://deploy-preview-26749--kubernetes-io-master-staging.netlify.app

sftim
sftim previously requested changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richarddli

I really like the idea of an article on this topic. I have one strong concern and all the other feedback is minor things. The strong concern is to make sure that readers who've heard a bit about https://github.com/kubernetes-sigs/service-catalog/ and https://svc-cat.io/ don't get mixed up and think those are the same as Service Catalog from Ambassador.

Would you be willing to revise this PR to make that clear?

richarddli and others added 7 commits March 1, 2021 08:09
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
ecd25df 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
eeb8c0b 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
69ee631 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
dc86d66 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
3188c43 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli @sftim
Update content/en/blog/_posts/2021-02-27-annotating-k8s-for-humans.md
a381d88 
Co-authored-by: Tim Bannister <[email protected]>
@richarddli
clarify difference with k8s service catalog
5b3eedc 
Signed-off-by: Richard Li <[email protected]>
@richarddli
Copy link
Contributor Author

@sftim Thank you for the excellent feedback. I incorporated all of your suggestions and added some more explanation of the difference between the Kubernetes service catalog and the general "Category" of service catalogs. It's a little confusing, but the term service catalog has at this point been fairly well popularized by the Spotify team in particular, so I'm glad you called this out.

@richarddli
Copy link
Contributor Author

@sftim @kbarnard10 Hello! Just a friendly poke to see if you had any other feedback. Thanks! 😀

@richarddli
Copy link
Contributor Author

@bobbytables @kbarnard10 Just another poke; is there anything I need to do here? Thanks! 😀

@richarddli
Copy link
Contributor Author

@bobbytables @kbarnard10 hello, just checking in on this!

@sftim sftim dismissed their stale review March 17, 2021 18:59

Superseded

sftim
sftim reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a quick scan, the latest revision LGTM

I'd squash the commits @richarddli (but you might want to wait until we've assigned a publication date).

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2021
@zacharysarah
Copy link
Contributor

/lgtm
/approve

Explicit hold for blog owners: feel free to /hold cancel at any time, including before 12 April. @kbarnard10 @onlydole @mrbobbytables
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 192d217294c7c56f0d4d856bf510382cd6707a10

@sftim
Copy link
Contributor

sftim commented Apr 8, 2021

@divya-mohan0209 is this publication date OK? It's not related to the v1.21 release

@divya-mohan0209
Copy link
Contributor

@divya-mohan0209 is this publication date OK? It's not related to the v1.21 release

@sftim Thank you so much for checking in. One of the Blog posts related to 1.21 is coming out on April 12th & there'll be a blogpost every alternate day after that till April 23rd. If we could shift this one to either the 13th/15th next week, that would be great.

@richarddli
Copy link
Contributor Author

Just checking on the scheduling of this -- fine with either 😀

@sftim
Copy link
Contributor

sftim commented Apr 12, 2021 •
edited
Loading

I think actually there might be a different article penciled in for the 15th. Maybe the first free slot in the following week?
See #27200 (comment)

@richarddli
Copy link
Contributor Author

@sftim Sounds good! Can we get it locked please?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

With updated publication date from #26749 (review)

Echoing LGTM and approval from #26749 (comment)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cff384dc0e11493e14ee7f696e6a954eccce6177

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2021
@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

@richarddli thanks for this article!

@sftim
Copy link
Contributor

sftim commented Apr 13, 2021

Scheduled for automatic publication on 2021-04-20

@k8s-ci-robot k8s-ci-robot merged commit 0fdc9cc into kubernetes:master Apr 13, 2021
mrbobbytables added a commit to mrbobbytables/website that referenced this pull request Apr 20, 2021
@mrbobbytables
Revert "Merge pull request kubernetes#26749 from richarddli/kubectl-a…
6069046 
…nnotate"

Removes annotation blog post

This reverts commit 0fdc9cc, reversing
changes made to 7c77d75.
@richarddli richarddli deleted the kubectl-annotate branch April 21, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

@kbarnard10 kbarnard10 kbarnard10 left review comments

@sftim sftim sftim left review comments

Assignees

@zacharysarah zacharysarah

@mrbobbytables mrbobbytables

@kbarnard10 kbarnard10

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richarddli @celestehorgan @zacharysarah @k8s-ci-robot @sftim @divya-mohan0209 @kbarnard10 @mrbobbytables