Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog image OWNERS #18571

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

mrbobbytables
Copy link
Member

Noticed in #18229 (comment) That the approve label wasn't applied because their blog post had images.

This adds a copy of the owners file in content/en/blog to the blog sub-directory under static/images.

/cc @kbarnard10 @castrojo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 9, 2020
@onlydole
Copy link
Member

onlydole commented Jan 9, 2020

/lgtm
/honk

@k8s-ci-robot
Copy link
Contributor

@onlydole:
goose image

In response to this:

/lgtm
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020
@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 9, 2020

Hi @mrbobbytables , Just checking: does this change permit only the blog team to approve
changes to static images (static/images/blog) or add the blog team to the approver list for this section of the ks8/website code base?

@castrojo
Copy link
Member

castrojo commented Jan 9, 2020

/approve

@mrbobbytables
Copy link
Member Author

It allows the blog team to approve changes to static/images/blog content to coincide with content/en/blog.

Currently, blog-approvers can approve blog content under content/en/blog, however if the blog post includes an image, an additional approve is needed from a root level approver.

@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 9, 2020

@mrbobbytables , OK, I understand. The current directory structure is very intertwined.
It would be an improvement if the different content is contained within a distinct directory structure.

@onlydole
Copy link
Member

onlydole commented Jan 9, 2020

/assign @zacharysarah

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9caaac3 into kubernetes:master Jan 10, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@mrbobbytables mrbobbytables deleted the add-blog-image-owners branch December 22, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants