-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog image OWNERS #18571
Add blog image OWNERS #18571
Conversation
/lgtm |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mrbobbytables , Just checking: does this change permit only the blog team to approve |
/approve |
It allows the blog team to approve changes to static/images/blog content to coincide with content/en/blog. Currently, blog-approvers can approve blog content under content/en/blog, however if the blog post includes an image, an additional approve is needed from a root level approver. |
@mrbobbytables , OK, I understand. The current directory structure is very intertwined. |
/assign @zacharysarah |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: castrojo, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Noticed in #18229 (comment) That the approve label wasn't applied because their blog post had images.
This adds a copy of the owners file in content/en/blog to the blog sub-directory under static/images.
/cc @kbarnard10 @castrojo