Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added blog post about Kubernetes on MIPS #18229

Merged
merged 31 commits into from
Jan 14, 2020
Merged

Added blog post about Kubernetes on MIPS #18229

merged 31 commits into from
Jan 14, 2020

Conversation

ydcool
Copy link
Contributor

@ydcool ydcool commented Dec 21, 2019

Signed-off-by: Dominic Yin [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @ydcool!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 21, 2019
@ydcool
Copy link
Contributor Author

ydcool commented Dec 21, 2019

/assign @jimangel

sftim
sftim reviewed Dec 21, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Here's some informal feedback with suggestions for grammar & styling.

content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
@ydcool
Copy link
Contributor Author

ydcool commented Dec 22, 2019

@sftim Thank you for your advice, content updated.

@ydcool ydcool requested a review from sftim December 22, 2019 01:05
@ydcool ydcool mentioned this pull request Dec 23, 2019
Closed
@onlydole
Copy link
Member

/assign @onlydole

onlydole
onlydole requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar and flow nitpicks

content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md Outdated Show resolved Hide resolved
@ydcool ydcool requested review from onlydole and sftim December 27, 2019 01:53
@ydcool
Copy link
Contributor Author

ydcool commented Dec 27, 2019

@onlydole sorry didn't see the hidden conversations before, all resolved now.

@onlydole
Copy link
Member

No worries! Thanks @ydcool!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2019
@ydcool
Copy link
Contributor Author

ydcool commented Jan 9, 2020

ping @onlydole @jimangel @mrbobbytables for approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2020
@mrbobbytables
Copy link
Member

Sorry for the delay in getting to review -- was out of the office for a bit.
From a technical perspective, everything looks good.
I've updated the dates in the filename to bump them to today and approved with a hold. Once @castrojo or @kbarnard10 signs off the hold can be lifted and it should be published.
/assign @kbarnard10 @castrojo
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2020
@mrbobbytables
Copy link
Member

mrbobbytables commented Jan 9, 2020 •
edited
Loading

Hm, weird - it didn't add approve on here...trying again:

/approve

EDIT: It's because there are images. Blog owners only have rights over the blog sub-directory. Woops 🤦‍♂

EDIT2: Opened PR to add owners for blog images - #18571

@mrbobbytables mrbobbytables mentioned this pull request Jan 9, 2020
Merged
@onlydole
Copy link
Member

@mrbobbytables / @kbarnard10 - any objections to approving this post (we should be good on permissions now!)

@mrbobbytables
Copy link
Member

Lets schedule this for Wednesday the 15th. I'll update the posting date and we can merge.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@onlydole
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit c3aea9e into kubernetes:master Jan 14, 2020
@onlydole onlydole mentioned this pull request Jan 14, 2020
Merged
@ydcool ydcool deleted the master branch January 19, 2020 08:37
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@ydcool @sftim
@onlydole @mrbobbytables @wawa0210
Added blog post about Kubernetes on MIPS (kubernetes#18229)
566d318 
* Added blog post about Kubernetes on MIPS

Signed-off-by: Dominic Yin <[email protected]>

* update content

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update 2019-12-21-Kubernetes-on-MIPS.md

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update 2019-12-21-Kubernetes-on-MIPS.md

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* update image of blog 2019-12-21-kubernetes-on-mips

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update content/en/blog/_posts/2019-12-21-Kubernetes-on-MIPS.md

Co-Authored-By: Taylor Dolezal <[email protected]>

* Update filename and date for publish

* Update content/en/blog/_posts/2020-01-09-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update content/en/blog/_posts/2020-01-09-Kubernetes-on-MIPS.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update and rename 2020-01-09-Kubernetes-on-MIPS.md to 2020-01-15-Kubernetes-on-MIPS.md

Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Taylor Dolezal <[email protected]>
Co-authored-by: Bob Killen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@onlydole onlydole

@castrojo castrojo

@jimangel jimangel

@mrbobbytables mrbobbytables

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ydcool @k8s-ci-robot @onlydole @mrbobbytables @sftim @castrojo @jimangel @kbarnard10