Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go.mod replace for client-go by extracting required parts of boskos #26956

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Remove go.mod replace for client-go by extracting required parts of boskos #26956

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e76216
Extract parts of boskos into this repo and remove client-go's replace…
munnerz Jul 28, 2022
3cd2bf4
Remove 'flow' JSON field tag
munnerz Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kubetest/boskos/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ type Resource struct {
type ResourceEntry struct {
Type string `json:"type"`
State string `json:"state"`
Names []string `json:"names,flow"`
Names []string `json:"names"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we got really lucky with this one, the go json encoder still respects the first value and just ignores the flow

MaxCount int `json:"max-count,omitempty"`
MinCount int `json:"min-count,omitempty"`
LifeSpan *Duration `json:"lifespan,omitempty"`
Expand All @@ -130,7 +130,7 @@ func (re *ResourceEntry) IsDRLC() bool {

// BoskosConfig defines config used by boskos server
type BoskosConfig struct {
Resources []ResourceEntry `json:"resources,flow"`
Resources []ResourceEntry `json:"resources"`
}

// Metric contains analytics about a specific resource type
Expand Down