Remove go.mod replace for client-go by extracting required parts of boskos #26956
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
|
/retest seems like integration tests are failing on something that looks totally unrelated... 👀 |
|
let's put this package under |
|
My plan was to remove these files altogether once the boskos repository has upgraded to not depend on v11 of client-go - happy to write up a README advising others, but I wasn't anticipating this being very permanent 😊 |
munnerz
force-pushed
the
fixup-client-go
branch
2 times, most recently
from
d3b2dfe to
4db4241
Compare
|
Moved into |
kubetest/boskos/common/common.go
Outdated
| type ResourceEntry struct { | ||
| Type string `json:"type"` | ||
| State string `json:"state"` | ||
| Names []string `json:"names,flow"` |
There was a problem hiding this comment.
I'm looking into the origins of this flow statement (which trips up golangci-lint) and it seems to have been there since the very origins of boskos/mason: https://github.com/kubernetes/test-infra/pull/6676/files
It's not a valid json string, and I believe we can remove it altogether.. I'm going to add a commit to delete it, but if anyone knows what it's for or why it's needed, please speak now 😄
| @@ -116,7 +116,7 @@ type Resource struct { | |||
| type ResourceEntry struct { | |||
| Type string `json:"type"` | |||
| State string `json:"state"` | |||
| Names []string `json:"names,flow"` | |||
| Names []string `json:"names"` | |||
There was a problem hiding this comment.
Seems we got really lucky with this one, the go json encoder still respects the first value and just ignores the flow
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, BenTheElder, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Extracts the parts of boskos that this repository actually uses into a
third_partydirectory.This allows us to remove the
replacedirective, which will in turn allow for a PR against the boskos repository to do the same (after bumping tomainof k8s.io/test-infra).Once that's been done, I can create a PR to basically revert this PR and bump our dependency on boskos 😅
Closes #20421