Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/jobs: fix trigger regex for benchmarkjunit-canary image push job #23771

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 27, 2021

Related:

Images haven't been getting pushed to gcr.io/k8s-staging-test-infra/benchmarkjunit because the canary image push job was never triggering because of an incorrect run_if_changed regex leftover from copy-pasting

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this explains why the periodic job is failing though? https://testgrid.k8s.io/sig-testing-canaries#benchmark-demo

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjwagner
Copy link
Member

I don't think this explains why the periodic job is failing though? https://testgrid.k8s.io/sig-testing-canaries#benchmark-demo

Nevermind, I was confused that the job was failing even though the image existed since that appeared to be the problem. Now I see the image exists because you just added it a few minutes ago 👍

@k8s-ci-robot k8s-ci-robot merged commit 6ab6092 into kubernetes:master Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-test-infra.yaml using file config/jobs/image-pushing/k8s-staging-test-infra.yaml

In response to this:

Related:

Images haven't been getting pushed to gcr.io/k8s-staging-test-infra/benchmarkjunit because the canary image push job was never triggering because of an incorrect run_if_changed regex leftover from copy-pasting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the fix-benchmark-junit-canary branch September 27, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants