Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: use k8s-staging-test-infra images for some jobs #23737

Merged
merged 2 commits into from
Sep 24, 2021
Merged

config/jobs: use k8s-staging-test-infra images for some jobs #23737

merged 2 commits into from
Sep 24, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 24, 2021

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2021
@spiffxp spiffxp mentioned this pull request Sep 24, 2021
Open
77 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 24, 2021

/cc @ameukam @dims

ameukam
ameukam reviewed Sep 24, 2021
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
@@ -904,7 +904,7 @@ periodics:
path_alias: k8s.io/kubernetes
spec:
containers:
- image: gcr.io/k8s-testimages/benchmarkjunit:latest
- image: gcr.io/k8s-staging-test-infra/benchmarkjunit:latest
Copy link
Member

@ameukam ameukam Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not tag latest for this image. Do we still want to do the flip ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm looking into why the image is missing...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #23771 to address

I'm going to use gcrane to manually sync something over in the meantime

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcrane copy gcr.io/{k8s-testimages,k8s-staging-test-infra}/benchmarkjunit:latest

@dims
Copy link
Member

dims commented Sep 24, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1544aef into kubernetes:master Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key structured-merge-diff-ci.yaml using file config/jobs/kubernetes-sigs/structured-merge-diff/structured-merge-diff-ci.yaml
  • key structured-merge-diff-presubmits.yaml using file config/jobs/kubernetes-sigs/structured-merge-diff/structured-merge-diff-presubmits.yaml
  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
  • key test-infra-canaries.yaml using file config/jobs/kubernetes/test-infra/test-infra-canaries.yaml
  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

Related:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the use-k8s-infra-images branch September 27, 2021 16:05
@spiffxp spiffxp mentioned this pull request Sep 27, 2021
Merged
@spiffxp spiffxp mentioned this pull request Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@apelisse apelisse Awaiting requested review from apelisse

@fejta fejta Awaiting requested review from fejta

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @dims @k8s-ci-robot @ameukam