Allow sig-release jobs to use preset-azure-cred #21576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the restricted secrets list to allow for sig-release jobs to use preset-azure-cred in periodic release informing jobs. Signed-off-by: hasheddan <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
BenTheElder
reviewed
Mar 30, 2021
| @@ -426,6 +426,7 @@ func TestTrustedJobSecretsRestricted(t *testing.T) { | |||
| "kubernetes-sigs/sig-windows": {secrets: getSecretsFromPreset(labels{"preset-azure-cred": "true"}), allowedInPresubmit: true}, | |||
| "kubernetes/sig-cloud-provider": {secrets: getSecretsFromPreset(labels{"preset-azure-cred": "true"}), allowedInPresubmit: true}, | |||
| "kubernetes/sig-network": {secrets: getSecretsFromPreset(labels{"preset-azure-cred": "true"}), allowedInPresubmit: true}, | |||
| "kubernetes/sig-release": {secrets: getSecretsFromPreset(labels{"preset-azure-cred": "true"})}, | |||
| "kubernetes-sigs/cluster-api-provider-azure": {secrets: getSecretsFromPreset(labels{"preset-azure-cred-only": "true"}), allowedInPresubmit: true}, | |||
There was a problem hiding this comment.
If it's allowed in presubmit there's not a lot of point to restricting it FWIW ...
There was a problem hiding this comment.
@BenTheElder do you mean preset-azure-cred in general?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the restricted secrets list to allow for sig-release jobs to use
preset-azure-cred in periodic release informing jobs.
Signed-off-by: hasheddan [email protected]
/assign @spiffxp @chewong
/cc @puerco @kubernetes/release-engineering
Unblocks #21557
Ref #21457 #20536
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/21557/pull-test-infra-bazel/1376909270888484864#1:build-log.txt%3A6388