Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-windows: create release signal dashboard on testgrid #21457

Merged
merged 3 commits into from
Mar 25, 2021
Merged

sig-windows: create release signal dashboard on testgrid #21457

merged 3 commits into from
Mar 25, 2021

Conversation

chewong
Copy link
Member

@chewong chewong commented Mar 19, 2021 •
edited
Loading

Signed-off-by: Ernest Wong [email protected]

The goal of this PR is to mimic https://testgrid.k8s.io/sig-release by removing redundant sig-windows testgrid dashboards and breaking them down into releases so we can have a clearer signal for each supported release

  • removed the following testgrid dashboards:
    • sig-windows-releases
    • sig-windows-containerd
    • sig-windows-azure
  • created the following testgrid dashboards:
    • sig-windows-1.18-release
    • sig-windows-1.19-release
    • sig-windows-1.20-release
    • sig-windows-master-release
    • sig-windows-containerd-hyperv
  • move all presets to presets.yaml
  • enforce presubmit job name - pull-<cluster provisioning tool>-<what the job is testisng>-<OS>-<container runtime>

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 19, 2021
@chewong chewong force-pushed the reorg-windows-testgrid branch from e204e15 to 7053dd9 Compare March 19, 2021 20:54
@chewong chewong marked this pull request as ready for review March 19, 2021 21:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2021
@chewong
Copy link
Member Author

chewong commented Mar 19, 2021

/assign @jsturtevant @marosset
/cc @jeremyje
since I edited some GCE windows jobs

@k8s-ci-robot k8s-ci-robot requested a review from jeremyje March 19, 2021 21:03
@chewong
Address PR comments
d0bfe6d 
Signed-off-by: Ernest Wong <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2021
@chewong chewong requested review from marosset and jsturtevant March 23, 2021 22:30
jsturtevant
jsturtevant reviewed Mar 23, 2021
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting out the presets!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@chewong
Copy link
Member Author

chewong commented Mar 24, 2021

/assign @feiskyer
from release-engineering-approvers

marosset
marosset approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for cleaning this up!

@chewong
Copy link
Member Author

chewong commented Mar 25, 2021

/hold
to prevent from being auto-merged for now
@feiskyer please still go ahead and review this PR. I will unhold this PR once it's approved. Thanks in advance

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
feiskyer
feiskyer reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dims
Copy link
Member

dims commented Mar 25, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, dims, feiskyer, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@chewong
Copy link
Member Author

chewong commented Mar 25, 2021

/unhold
Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit c1a8659 into kubernetes:master Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

@chewong: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key presets.yaml using file config/jobs/kubernetes-sigs/sig-windows/presets.yaml
  • key release-1.18-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.18-windows.yaml
  • key release-1.19-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.19-windows.yaml
  • key release-1.20-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-1.20-windows.yaml
  • key sig-windows-config.yaml using file ``
  • key release-master-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml
  • key sig-windows-containerd-hyperv.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-containerd-hyperv.yaml
  • key sig-windows-kubeadm.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-kubeadm.yaml
  • key sig-windows-sac.yaml using file config/jobs/kubernetes-sigs/sig-windows/sig-windows-sac.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key 1.20.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.20.yaml
  • key windows-gce.yaml using file config/jobs/kubernetes/sig-windows/windows-gce.yaml

In response to this:

Signed-off-by: Ernest Wong [email protected]

The goal of this PR is to mimic https://testgrid.k8s.io/sig-release by removing redundant sig-windows testgrid dashboards and breaking them down into releases so we can have a clearer signal for each supported release

  • removed the following testgrid dashboards:
  • sig-windows-releases
  • sig-windows-containerd
  • sig-windows-azure
  • created the following testgrid dashboards:
  • sig-windows-1.18-release
  • sig-windows-1.19-release
  • sig-windows-1.20-release
  • sig-windows-master-release
  • sig-windows-containerd-hyperv
  • move all presets to presets.yaml
  • enforce presubmit job name - pull-<cluster provisioning tool>-<what the job is testisng>-<OS>-<container runtime>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chewong chewong deleted the reorg-windows-testgrid branch March 25, 2021 16:43
@hasheddan hasheddan mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant requested changes

@feiskyer feiskyer feiskyer left review comments

@marosset marosset marosset approved these changes

@ddebroy ddebroy Awaiting requested review from ddebroy

@jeremyje jeremyje Awaiting requested review from jeremyje

Assignees

@jsturtevant jsturtevant

@feiskyer feiskyer

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@chewong @k8s-ci-robot @dims @jsturtevant @feiskyer @marosset