Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pmorie/go-open-service-broker-client to kubernetes-sigs/go-open-service-broker-client #893

Closed
jberkhahn opened this issue Jun 6, 2019 · 11 comments · Fixed by kubernetes/community#4065
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog.
Milestone

Comments

@jberkhahn
Copy link
Contributor

New Repo, Staging Repo, or migrate existing

migrate existing

Requested name for new repository

go-open-service-broker-client

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

the kubernetes-sigs team service-catalog-admins

If not a staging repo, who should have write access

the kubernetes-sigs team service-catalog-maintainers

If not a staging repo, who should be listed as approvers in OWNERS

the kubernetes-sigs team service-catalog-maintainers

If not a staging repo, who should be listed in SECURITY_CONTACTS

jberkhahn

What should the repo description be

A golang client for service brokers implementing the Open Service Broker API

What SIG and subproject does this fall under in sigs.yaml

this is part of the main service catalog project for sig-service-catalog.
it is already in use in the main repo, we're just moving it over to be under control
of the sig

Approvals

Please prove you have followed the appropriate approval process for this new
repo by including links to the relevant approvals (meeting minutes, e-mail
thread, etc.)
this was discussed at the April 22 meeting of SIG Service Catalog: link
pmorie's approval was obtained privately by @jboyd01

Additional context for request

@pmorie will need to involved in moving this

@jberkhahn jberkhahn added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Jun 6, 2019
@nikhita
Copy link
Member

nikhita commented Jun 7, 2019

The meetings notes say Discuss moving OSB Client API from pmorie to OSB GitHub org or Kub-Sig.

pmorie's approval was obtained privately by @jboyd01

@pmorie can you explicitly lgtm here for the record? Thanks!

@nikhita
Copy link
Member

nikhita commented Jun 7, 2019

Donated repos need to satisfy some requirements. As per these requirements, the following steps need to be done before the migration:

@nikhita
Copy link
Member

nikhita commented Jun 7, 2019

/assign

@mook-as
Copy link

mook-as commented Jun 12, 2019

Huh, I seem to have missed the mail for this one somehow. Luckily, I've got my CLA fixed over in #894, so there's no action for me to do here at this point. 🎉

@jberkhahn
Copy link
Contributor Author

Any update on this?

@nikhita
Copy link
Member

nikhita commented Jul 23, 2019

/assign @pmorie
for final go ahead

For the record, got an lgtm for this on slack - https://kubernetes.slack.com/archives/C232SF3TK/p1563895810010100.

I can take care of the OWNERS files, etc post migration but the copyright boilerplate will need to be added pre-migration because of legal rules...

@pmorie
Copy link
Member

pmorie commented Jul 24, 2019

/lgtm

@spiffxp spiffxp added this to the v1.16 milestone Jul 31, 2019
@spiffxp spiffxp added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. labels Jul 31, 2019
@jberkhahn
Copy link
Contributor Author

any update on this? what else needs to be done?

@nikhita
Copy link
Member

nikhita commented Aug 20, 2019

kubernetes-retired/go-open-service-broker-client#139 fixes the boilerplate for all files

@nikhita
Copy link
Member

nikhita commented Sep 6, 2019

Repo has been migrated: https://github.com/kubernetes-sigs/go-open-service-broker-client and relevant teams have been granted access.

I have created kubernetes/community#4065 to add the repo to sigs.yaml. Once the PR merges, we can close this issue.

@jberkhahn
Copy link
Contributor Author

BAM! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants