Add script to verify boilerplate header #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
(Will fix the verify error, wanted to check if it fails on ci) |
We should use the default Kubernetes boilerplate for generated files.
nikhita
force-pushed
the
verify-boilerplate-script
branch
from
785a1ec to
5f52748
Compare
|
@xmudrii Ptal. Updated, now all tests are green. ✨ |
|
Merging. Also, marked the verify job as "required". |
This was referenced Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to make sure that all files contain the correct Kubernetes copyright boilerplate header. It is a prerequisite for migrating the repo to upstream: #105.
Release note: