-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rolling update strategy to each static deployment file #10129
Add rolling update strategy to each static deployment file #10129
Conversation
Signed-off-by: z1cheng <[email protected]>
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @z1cheng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to these generated files need to be updated, I guess the files that generate the rules also need to be modified
@tao12345666333 Thanks a lot! Will update the templates and regenerate the deployment files😄 |
Signed-off-by: z1cheng <[email protected]>
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label tide/merge-method-squash
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tao12345666333, z1cheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add rolling update strategy to each static deployment file.
Types of changes
Which issue/s this PR fixes
fixes #10121
How Has This Been Tested?
Checklist: