Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Ingress-controller - No explicit rollingUpdate strategy defined #10121

Closed
luarx opened this issue Jun 22, 2023 · 3 comments · Fixed by #10129
Closed

AWS Ingress-controller - No explicit rollingUpdate strategy defined #10121

luarx opened this issue Jun 22, 2023 · 3 comments · Fixed by #10129
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@luarx
Copy link

luarx commented Jun 22, 2023

What happened:
There is not an explicit rolling update strategy defined in AWS static files as it is in other places as:

strategy:
rollingUpdate:
maxUnavailable: 1
type: RollingUpdate

What you expected to happen:

Probably it was removed by mistake, I think that in the past it was defined.

@luarx luarx added the kind/bug Categorizes issue or PR as related to a bug. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jun 22, 2023
@strongjz
Copy link
Member

/good-first-issue
/triage accepted
/priority backlog
/help-wanted

Looks like kind is the only one with a rolling update, so whoever takes this we should look to add it to all the static deployment files.

grep -r "type: RollingUpdate" deploy/static/provider/
deploy/static/provider/kind/deploy.yaml:    type: RollingUpdate

@k8s-ci-robot
Copy link
Contributor

@strongjz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/triage accepted
/priority backlog
/help-wanted

Looks like kind is the only one with a rolling update, so whoever takes this we should look to add it to all the static deployment files.

grep -r "type: RollingUpdate" deploy/static/provider/
deploy/static/provider/kind/deploy.yaml:    type: RollingUpdate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jun 22, 2023
@z1cheng
Copy link
Member

z1cheng commented Jun 25, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants