Add sig labels and use aliases in OWNERS files #1283
Conversation
k8s-ci-robot
added
size/XL
| approvers: | ||
| - sig-cloud-provider-leads | ||
| labels: | ||
| - sig/cloud-provider |
There was a problem hiding this comment.
We don't have this label.
| - dghubble | ||
| - sig-on-premise-leads | ||
| labels: | ||
| - sig/onprem |
There was a problem hiding this comment.
Hope the names can be consistent one day... onprem vs on-premise
ref: #703
There was a problem hiding this comment.
I hope they can to. This isn't to change that though -- just capturing the current state of the world.
| - calebamiles | ||
| - sig-product-management-leads | ||
| labels: | ||
| - sig/pm |
There was a problem hiding this comment.
pm vs product-management
|
I like the idea in theory, but I'm concerned that this conflates sig-lead with technical lead. Sig leads are responsible for organizing and driving the sig and if I recall correctly, there was an explicit decision to keep sig leads separate from tech leads. That said, it seems to make sense for most of the design proposals dirs as it's a direct replacement of names with alias. |
|
@grodrigues3 I figured this was a good starting place. Most of the |
|
This sounds good to me. I'll tag contribX and see if we get any additional feedback. otherwise, i'll LGTM this afternoon. @kubernetes/sig-contributor-experience-pr-reviews |
k8s-ci-robot
added
the
sig/contributor-experience
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Automatic merge from submit-queue. Add sig labels and use aliases in OWNERS files This PR does the following: - Creates a sig-*-leads alias for all sigs and working groups - Replaces the reviewers/approvers in the sig folders and design-proposals folders with that alias - Adds a label field to the OWNERS files to allow for automatic sig labelling (kubernetes/test-infra#3502)
This PR does the following: