Skip to content

sig name consistency #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spiffxp opened this issue Jun 9, 2017 · 21 comments
Closed

sig name consistency #703

spiffxp opened this issue Jun 9, 2017 · 21 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@spiffxp
Copy link
Member

spiffxp commented Jun 9, 2017

There are a number of places where sig names are ever-so-slightly inconsistent. I'd like us to link back to this issue when we identify those areas. Update docs, preferably adjust what we can.

For a sig foo, I expect:

Examples of where we've hit inconsistencies:

EDIT: Is it reasonable to expect the same for working groups as well?

@spiffxp
Copy link
Member Author

spiffxp commented Jun 9, 2017

FYI @kubernetes/sig-contributor-experience-misc

@spiffxp
Copy link
Member Author

spiffxp commented Jun 9, 2017

FYI @xiangpengzhao

@xiangpengzhao
Copy link
Contributor

+1000

It would be good to also have our sig meeting channels follow the name consistency.

In the page SIGs and Working Groups, we use hangouts or zoom to hold meetings. And some meeting channels use number as id and others use name string.

@spiffxp

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2017
@cblecker cblecker added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Aug 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2017
@spiffxp
Copy link
Member Author

spiffxp commented Oct 20, 2017

ping @castrojo since we were talking about this the other day

@idvoretskyi
Copy link
Member

big +1

@castrojo
Copy link
Member

So what I was thinking was proposing something to the SIG governance document that reads something like "The entry dir: sig-api-machinery in sigs.yaml becomes the machine-consumable naming convention that all your other resources inherit."

Then we make sure the slack channels, etc. align up. Renaming the slack channels is easy, we just renamed #sig-scale without problems. Not sure on how disruptive renaming google groups. I think the annoying bit will be the Zoom channels and calendars, which seems to be a mixture of numbers and shortcuts.

However I think we can make the argument to all the leads that being able to just guess the channel name based on convention will be very useful for people, for example I would be able to guess that zoom.us/j/sig-ui is the right room. Calendars will be annoying but making SIGs follow this convention will lead to improved tooling and consistency.

@cblecker
Copy link
Member

we can change/update sigs.yaml as needed.. there's actually three lines in there (dir, name, label) that are all similar. Having one as the source of truth, and then changing around the generator as needed would work

@bgrant0607
Copy link
Member

bgrant0607 commented Oct 24, 2017 via email

@spiffxp
Copy link
Member Author

spiffxp commented Oct 24, 2017

re: zoom-channels, you only get one vanity url aka "Personal Link" via https://zoom.us/profile

Personal Link is an alias of your personal meeting URL https://zoom.us/j/REDACTED.
It must be 5 to 40 characters.
It must start with a letter and can contain only letters (a-z), numbers (0-9) and periods (".")

Couldn't use a dash, so now I've got https://zoom.us/my/k8s.sig.testing, WDYT?

Only other URL I've seen is https://zoom.us/my/kubernetescommunity

@idvoretskyi
Copy link
Member

idvoretskyi commented Oct 24, 2017 via email

@bgrant0607
Copy link
Member

dots are better than no punctuation.

An existing example:
https://zoom.us/my/sig.apps

k8s.sig.testing seems fine.

@spiffxp
Copy link
Member Author

spiffxp commented Nov 20, 2017

Fun (annoying) facts discovered while trying to reconcile for sig-contributor-experience

  • renaming a google group will break anything that attempts to use the old name
  • slack channel names are limited to 21 characters (sig-contributor-experience is 27)

So we're back to kuberenetes-wg-contribex and #sig-contribex for now

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2018
@cblecker
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2018
@cblecker
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 18, 2018
@spiffxp
Copy link
Member Author

spiffxp commented Jul 25, 2018

/lifecycle frozen
As a "known issue".

I'm not sure I ever foresee this getting fixed if the definition of done is "make everything the same". I think instead a successful answer to these questions would do it:

  • How could these conventions (and deviations from them) best be documented?
    • ie: I'm guessing somewhere in the docs around sig goverenance and sig creation there would be a list of all the things
  • Where should a person go to find out about these different things for a given SIG?
    • ie: maybe use sigs.yaml to hold this info and generate it into SIG READMEs?

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 25, 2018
@parispittman
Copy link
Contributor

sig-wg-lifecycle.md should cover most of these conventions along with the other governance doc updates recently. most of the naming convention information is included in each relevant section. do you think this is good @spiffxp?

contribex ml has also been changed to kubernetes-sig-contribex@

@spiffxp
Copy link
Member Author

spiffxp commented Mar 20, 2019

/close
Yes, I think between sigs.yaml evolving to hold much of this contact info, and the lifecycle doc spelling out how to implement most of the conventions, we're good here

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Yes, I think between sigs.yaml evolving to hold much of this contact info, and the lifecycle doc spelling out how to implement most of the conventions, we're good here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danehans pushed a commit to danehans/community that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

10 participants