Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend build platforms to include linux/s390x,linux/ppc64le #772

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

Huang-Wei
Copy link
Contributor

@Huang-Wei Huang-Wei commented Jul 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

With #771, we're able to build linux/amd64 and linux/arm64 in 27min. Let's see how it goes with two more platforms.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Update: It doesn't quite work

 582 #30 [linux/amd64 go-builder 4/4] RUN RELEASE_VERSION=v20240727-v0.28.8-83-g01153c80 make build-scheduler
 583 #30 DONE 260.6s

 597 #32 [linux/ppc64le go-builder 4/4] RUN RELEASE_VERSION=v20240727-v0.28.8-83-g01153c80 make build-scheduler
 598 #32 DONE 2489.9s

 615 #29 [linux/arm64 go-builder 4/4] RUN RELEASE_VERSION=v20240727-v0.28.8-83-g01153c80 make build-scheduler
 616 #29 DONE 2606.0s

 630 #31 [linux/s390x go-builder 4/4] RUN RELEASE_VERSION=v20240727-v0.28.8-83-g01153c80 make build-scheduler
 631 #31 DONE 2887.0s

......

1078 #29 [linux/amd64 go_builder 4/4] RUN make build-controller
1082 #29 0.478 GOOS=linux CGO_ENABLED=0 go build -ldflags '-w' -o bin/controller cmd/controller/controller.go
1083 #29 ...

1085 #30 [linux/ppc64le go_builder 4/4] RUN make build-controller
1089 #30 1.703 GOOS=linux CGO_ENABLED=0 go build -ldflags '-w' -o bin/controller cmd/controller/controller.go
1090 #30 ...

1092 #31 [linux/arm64 go_builder 4/4] RUN make build-controller
1096 #31 1.608 GOOS=linux CGO_ENABLED=0 go build -ldflags '-w' -o bin/controller cmd/controller/controller.go
1097 #31 ...

1099 #32 [linux/s390x go_builder 4/4] RUN make build-controller
1103 #32 1.368 GOOS=linux CGO_ENABLED=0 go build -ldflags '-w' -o bin/controller cmd/controller/controller.go
1104 TIMEOUT
1105 ERROR: context deadline exceeded
1106 make: *** [Makefile:64: build-images] Terminated

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from PiotrProkop July 27, 2024 23:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from seanmalloy July 27, 2024 23:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2024
Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 7bc1425
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66a581d6c105bd0008c47fda

@Huang-Wei Huang-Wei merged commit 01153c8 into kubernetes-sigs:master Jul 27, 2024
9 of 10 checks passed
@Huang-Wei Huang-Wei deleted the extend-build-platforms branch July 27, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants