Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp Makefile and build scripts to adapt to 'docker buildx' in local and cloudbuild #771

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

Huang-Wei
Copy link
Contributor

@Huang-Wei Huang-Wei commented Jul 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

The previous PRs for distroless build don't work for various kinds of reasons. This PR revamps Makefile and build scripts to adapt to 'docker buildx' in local and cloudbuild.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

revamp Makefile and build scripts to adapt to 'docker buildx' in local and cloudbuild

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2024
Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit f07b943
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66a571d8cb9eed0008956802

@Huang-Wei Huang-Wei merged commit 50277bf into kubernetes-sigs:master Jul 27, 2024
9 of 10 checks passed
@Huang-Wei Huang-Wei deleted the reduce-build-time branch July 27, 2024 22:36
@Huang-Wei
Copy link
Contributor Author

The latest image build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants