update .go-version to 1.17.13 and go mod tidy #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/L
go install sigs.k8s.io/kubetest2/...(at)latest was failing for go 1.17, somehow deciding to pull in dependencies that require go >= 1.18 go build ./... was refusing to build for go 1.17, saying that go mod tidy needed to be run first (see https://go.dev/ref/mod#go-mod-file-go for why) The Makefile used as the entrypoint for all of this project's CI jobs uses the go version specified in .go-version so we were missing this failure mode
opted to do this as a separate verify script instead of in hack/build/setup-go.sh because: - failures in that script are silent as far as `make` is concerned - maybe there's a testing reason someone would want to explicitly try using an older version of go than is specified in go.mod
spiffxp
force-pushed
the
go1.17-followup
branch
from
31bc562 to
6a75690
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MushuEE, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
go install sigs.k8s.io/kubetest2/...@latestwas failing for go 1.17, somehow deciding to pull in dependencies that require go >= 1.18 despite #207go build ./...was refusing to build for go >= 1.17, saying that go mod tidy needed to be run first (see https://go.dev/ref/mod#go-mod-file-go for why)The Makefile used as the entrypoint for all of this project's CI jobs uses the go version specified in
.go-versionso we were missing this failure mode. Added ago-versiontarget which gets run as part ofmake verifyto hopefully catch this in the future