-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sigs.k8s.io/boskos #207
Conversation
Interesting! kubernetes/test-infra@0e771b6 introduces generics. We can't use that here since kubetest2 still uses Go 1.17. Updating Go is a different concern right now.
Trying to find a Boskos version which uses a k/test-infra version before generics were added. |
Signed-off-by: Nabarun Pal <[email protected]>
e48658a
to
44b3068
Compare
/assign @BenTheElder @MushuEE |
/approve |
ugh, we really should consider breaking the dependency on test-infra here, that is not a fun repo to have as a dependency :/ thanks for the PR |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, palnabarun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I agree. We need to see how we can change that dependency. |
The best answer is probably copying in our own boskos client like @munnerz did in test-infra, boskos client is pretty simple and stable, and the API is not really changing. I'm going to file a test-infra bug about generics use though, this is problematic given we have kubernetes versions without it yet. |
Yes please. Thank you! I was wondering how we got the generics change in. I like the policy you wrote in kubernetes/community#6693 and should ideally want to get it in soon. |
I will try to make this change. |
This can potentially fix kubernetes/kubernetes#111584
Ran the following:
Using kubernetes-sigs/boskos@37bd9bb because that's the last commit of boskos which doesn't pull in k/test-infra code which uses Generics.
Signed-off-by: Nabarun Pal [email protected]