-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update controller-tools version (v0.9.2->v0.10.0) #2956
Conversation
Hi @oscr, Thank you for the PR. We need to update it in the scaffolds and not only in the CLI, see:
Also, we need to run make, generate and update the samples. |
Thank you @camilamacedo86! 🙏 That's why I didn't get any generate diff. |
259a499
to
a04f986
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇
But we need to sort out the legacy test. it might be related to go versions, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/unit-tests-legacy.yml
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, oscr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a04f986
to
ce0a2d1
Compare
Ah I see now that controller-tools will be updated as part of this PR. I was working on #2954 as part of updating the CLI go.mod to use k8s 1.25 dependencies and just pushed a controller-tools bump and a bump to the Go version in https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/unit-tests-legacy.yml |
@oscr @camilamacedo86 I will work on fixing the legacy unit test action as part of PR #2954 and back out my controller-tools bump. Once #2954 is merged, then we should be good to merge this one. |
@everettraven That's awesome! Thank you so much for that 🙏 |
Hi @oscr, just bump with the master to get #2954 so that will pass and we can merge this one. c/c @everettraven |
ce0a2d1
to
fbd7497
Compare
Updates the go dependency sigs.k8s.io/controller-tools from v0.9.2- to v0.10.0
Part of #2908